Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions core/engine.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
from __future__ import annotations

import logging
import re
from datetime import datetime, timezone

from .atomics import get_all_techniques, get_technique, get_test
Expand Down Expand Up @@ -113,6 +114,26 @@ def run_test(
effective_timeout = timeout if timeout is not None else self.default_timeout
input_args = input_arguments or {}

if not isinstance(input_args, dict):
return {
"success": False,
"error": "input_arguments must be an object/dictionary.",
}

# Block shell metacharacters in user-provided substitutions to avoid command injection.
unsafe_pattern = re.compile(r"[;&|`$<>\\n\\r]")
for arg_name, arg_value in input_args.items():
if not isinstance(arg_value, (str, int, float, bool)):
return {
"success": False,
"error": f"Invalid input argument type for {arg_name!r}.",
}
if isinstance(arg_value, str) and unsafe_pattern.search(arg_value):
return {
"success": False,
"error": f"Unsafe characters detected in input argument {arg_name!r}.",
}

# Substitute variables in command
command = substitute_variables(
test["command"], input_args, test.get("input_arguments", {})
Expand Down
Loading