Potential fix for code scanning alert no. 3: Uncontrolled command line - #1
Merged
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ) | ||
| try: | ||
| proc = subprocess.run( | ||
| ps_args, |
… line' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Rootless-Ghost
marked this pull request as ready for review
April 13, 2026 14:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/Rootless-Ghost/AtomicLoop/security/code-scanning/3
Best fix: stop embedding user-influenced values into a PowerShell command string. Instead, pass the script via
-Fileand pass parameters as separate process arguments so they are not re-parsed as executable code. Also validatelog_sourcesagainst an allowlist of supported channel names before serialization.Concretely in
core/event_collector.py:tempfileimport.collect_events, sanitizelog_sourcesto only permitted entries fromDEFAULT_LOG_SOURCES(fallback to defaults if none valid)._query_wel, write_PS_COLLECTto a temporary.ps1file and call:powershell.exe -NonInteractive -NoProfile -File <tmp.ps1> -StartTime <...> -LogNamesJson <...> -MaxPerLog <...>This removes
-Commandstring construction and prevents command injection through interpolated text.No behavior change to successful collection logic/output.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.