fix(fuselage): improve ghost badge contrast - #2144
Open
ivans-netto wants to merge 1 commit into
Open
Conversation
The ghost badge used pure-white text over stroke-dark, which made it identical to the secondary variant in the light theme and unreadable (~2.5:1) in the dark theme. It now uses font-titles-labels over badge-background-level-0, meeting WCAG AA in all themes. Also adds a Ghost story and reworks the WithValue story to show every badge variant labeled with its name. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 4ed21b3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
ghostbadge variant usedpure-whitetext overstroke-dark, which had two problems:stroke-dark(#6C737A) is the same color asbadge-level-1, so ghost was visually identical tosecondary, and the white text sat at a borderline ~4.8:1 contrast.stroke-darkresolves to #9EA2A8, dropping white text to ~2.5:1 — failing WCAG AA.It now uses
font-titles-labelsoverbadge-background-level-0(the previously unused neutral badge token, already paired with a dark font by the message highlight styles):All meet WCAG AA (4.5:1) for the badge's micro font size, and ghost is now visually distinct from
secondary.Before / After
Before
After
Storybook
Ghoststory (there was none) with a smoke test.WithValueto show every badge variant with its value and a label with the variant name.Testing
yarn jest Badge.spec— 12/12 passingGhost, regenerated golden forWithValue, no other goldens changedpatch)🤖 Generated with Claude Code