Skip to content

Introduce Zizmore to audit Github actions #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zetter-rpf wants to merge 6 commits into
base: main
Choose a base branch
from
+32 −9
Open

Introduce Zizmore to audit Github actions #946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d1fe3a3
Add zizmor config ignoring all current findings
zetter-rpf Aug 5, 2026
4888ee6
Fix zizmor artipacked findings in ci.yml
zetter-rpf Aug 5, 2026
dc27762
Fix zizmor unpinned-uses findings
zetter-rpf Aug 5, 2026
f648802
Add zizmor CI step to lint GitHub Actions workflows
zetter-rpf Aug 5, 2026
5e6705e
Ignore trusted image warning
zetter-rpf Aug 5, 2026
5c56300
Pin zizmor version in CI
zetter-rpf Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 30 additions & 7 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,13 @@ jobs:
timeout-minutes: 20

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 # v4.4.0

@cursor cursor Bot Aug 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinned actions lack Dependabot

Medium Severity

Actions were switched from floating tags to immutable SHAs, but Dependabot still only watches bundler. Those pins will not receive automated update PRs, so security fixes in checkout, setup-ruby, upload-artifact, stale, and setup-uv can sit unpatched until someone updates them by hand.

Additional Locations (2)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 5e6705e. Configure here.

@zetter-rpf zetter-rpf Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a tradeoff. I'm not sure how common security issues are in actions

with:
persist-credentials: false


- name: Set up Ruby and bundle cache
uses: ruby/setup-ruby@v1
uses: ruby/setup-ruby@95ef2b042f9d7a56d8268cba8559e2842e2ad01b # v1.321.0
with:
ruby-version: .tool-versions
bundler-cache: true
Expand All @@ -35,6 +37,25 @@ jobs:
- name: Run RuboCop
run: bundle exec rubocop --format progress

zizmor:
runs-on: ubuntu-latest
timeout-minutes: 5
permissions:
contents: read

steps:
- uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 # v4.4.0
with:
persist-credentials: false

- name: Install uv
uses: astral-sh/setup-uv@c771a70e6277c0a99b617c7a806ffedaca235ff9 # v9.0.0

- name: Run zizmor
run: uvx "zizmor@1.29.0" .
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Comment thread
zetter-rpf marked this conversation as resolved.

test:
runs-on: ubuntu-latest
timeout-minutes: 45
Expand Down Expand Up @@ -79,7 +100,7 @@ jobs:
ports:
- 6379:6379
salesforce_connect:
image: 'ghcr.io/raspberrypifoundation/heroku-connect'
image: 'ghcr.io/raspberrypifoundation/heroku-connect' # zizmor: ignore[unpinned-images]
Comment thread
zetter-rpf marked this conversation as resolved.
credentials:
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
Expand All @@ -96,18 +117,20 @@ jobs:
--health-retries=5

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 # v4.4.0
with:
persist-credentials: false

- name: Install test dependencies
run: >
sudo apt-get update && sudo apt-get install --yes --no-install-recommends
libvips

- name: Set up Firefox
uses: browser-actions/setup-firefox@v1
uses: browser-actions/setup-firefox@0bc507ddf224827e3b1af68e014d5e42ab93e795 # v1.7.2

- name: Set up Ruby and bundle cache
uses: ruby/setup-ruby@v1
uses: ruby/setup-ruby@95ef2b042f9d7a56d8268cba8559e2842e2ad01b # v1.321.0
with:
ruby-version: .tool-versions
bundler-cache: true
Expand All @@ -130,7 +153,7 @@ jobs:

- name: Upload coverage artifact
if: always()
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
with:
name: coverage
path: coverage
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/close_stale_issues_and_prs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
stale:
runs-on: ubuntu-latest
steps:
- uses: actions/stale@v10
- uses: actions/stale@1e223db275d687790206a7acac4d1a11bd6fe629 # v10.4.0
with:
operations-per-run: 50
stale-issue-message: 'This issue is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.'
Expand All @@ -22,4 +22,4 @@ jobs:
days-before-issue-stale: 90
days-before-pr-stale: 30
days-before-issue-close: 7
days-before-pr-close: 7
days-before-pr-close: 7
Loading