chore: Don't copy node_modules into GitHub pages deployment - #10246
Open
gonfunko wants to merge 2 commits into
Open
chore: Don't copy node_modules into GitHub pages deployment#10246gonfunko wants to merge 2 commits into
gonfunko wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Proposed Changes
This PR fixes deployment of the GitHub pages once again. Post-#10207, the playground no longer depends on any other node_modules, and post-monorepo the assumptions we were making about copying them no longer held, leading to dead symlinks that confused the GitHub pages deployer.