cute_tiled: Fix failure to load when objects have a 'propertytype' JSON field. - #439
Open
fsb-dev02 wants to merge 1 commit into
Open
cute_tiled: Fix failure to load when objects have a 'propertytype' JSON field.#439fsb-dev02 wants to merge 1 commit into
fsb-dev02 wants to merge 1 commit into
Conversation
Owner
|
Is this backwards compatible? |
Author
Yes, parsing simply continues as usual if there isn't a "propertytype" field to skip. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prevents a JSON parsing error when loading a map where one or more Tiled objects contained in it make use of a custom enum type. The parsing error happens because from Tiled 1.8 onwards, a new field "propertytype" was added in their JSON specifications (which defines the enum name), which cute_tiled does not currently account for and fails when encountering it. The changes make it so that cute_tiled will skip this propertytype field during parsing and read a custom enum as a normal int or string.
Below is a copy of the map from my project where i tested this:
rock_mnt.json