qkc/slave 04: implement baseConn and XshardConn compatibility layer - #32
Open
iteyelmp wants to merge 19 commits into
Open
qkc/slave 04: implement baseConn and XshardConn compatibility layer#32iteyelmp wants to merge 19 commits into
iteyelmp wants to merge 19 commits into
Conversation
# Conflicts: # qkc/cluster/wire/messages_test.go
qzhodl
reviewed
Aug 3, 2026
qzhodl
left a comment
There was a problem hiding this comment.
Please update the PR description to state explicitly whether a full Codex 5.6 review was run against the complete diff before submission, for example: Full Codex 5.6 review completed: yes/no.
My first Codex review of this PR found multiple correctness and lifecycle issues that the existing tests did not expose, including successful acknowledgements for discarded xshard data, unchecked response error codes, stale multi-shard routes, and timeout/late-response teardown. Please run a complete Codex review before submitting code, address or explicitly document its findings, and disclose the review status and any intentional incomplete stubs in the PR description.
qzhodl
reviewed
Aug 3, 2026
syntrust
reviewed
Aug 4, 2026
qzhodl
reviewed
Aug 4, 2026
qzhodl
reviewed
Aug 4, 2026
qzhodl
reviewed
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the foundational connection layer for cluster communication.
The main goal is to reproduce the Python cluster connection behavior in Go,
while keeping business logic migration out of scope.
Implemented
baseConn
Introduces the common connection abstraction used by future cluster
communication components.
Implemented:
XshardConn
Implements slave-to-slave communication on top of baseConn.
Implemented:
XshardPool
Adds connection management for xshard peers.
Implemented:
Full Codex 5.6 review completed: yes