fix(review): PR #345 follow-ups — error hints and live-test cleanup

[Zochory]

Summary

Narrow review follow-ups to #345 (Lakebase Postgres state), cut from feat/lakebase-postgres-state:

• Doctor remediation swallowed — run_daytona_doctor's database step collapsed the sanitized ensure_database_compatible exception into the fixed "Database connection or Alembic revision validation failed." string, so the shared remediation (run uv run python scripts/db_init.py``) never reached operators. The step message now appends the top-level sanitized message only for the closed DatabaseCompatibilityError/`DatabaseConnectionError` types; chained causes (paths, SQLAlchemy internals, secrets) stay hidden.
• Supervisor hint regression — the preflight catch-all (raise SupervisorError(str(exc))) dropped the actionable "verify FLEET_DATABASE_URL" hint for connection failures. The hint is restored (f"{exc}; verify FLEET_DATABASE_URL") while the dedicated DatabaseCompatibilityError path keeps the remediation message untouched.
• Live-test cleanup atomicity — test_lakebase_pooled_dml_round_trip used per-step session.commit() calls plus a second DELETE in finally on a possibly re-pinged connection, risking an orphaned fleet_users row on the shared dev instance. Insert/delete now run in engine.begin() transactional blocks and teardown is a single PK-scoped transactional DELETE; all SQL stays parameterized and assertions are unchanged.
• Flush comment accuracy — the two-phase flush comment claimed "parents are durable"; db.flush() does not commit. Reworded to describe dependency-ordered SQL statement ordering within one transaction.

Test plan

• uv run pytest tests/unit/backend/test_cli_supervisor.py tests/unit/backend/test_ensure_database_compatible.py tests/unit/backend/test_engine_pool_policy.py tests/unit/backend/test_daytona_diagnostics.py -q — 37 passed
• git diff --check — clean
• Live Lakebase proof (FLEET_LIVE=1) remains opt-in and unchanged in scope

Made with Cursor

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 0cf9eced-6dce-4656-a6c2-83fb64b608ca

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}