Skip to content

LaserLab v0.3.1 fixture provenance and golden regressions - #20

Merged
ProhibitedTV merged 1 commit into
mainfrom
codex/fixture-golden-regressions
Jul 10, 2026
Merged

LaserLab v0.3.1 fixture provenance and golden regressions#20
ProhibitedTV merged 1 commit into
mainfrom
codex/fixture-golden-regressions

Conversation

@ProhibitedTV

Copy link
Copy Markdown
Owner

Summary

  • makes fixture catalog metadata enforceable, including phenomena, licensing, attribution, expected detector behavior, limitations, and redistribution status
  • carries fixture provenance through ingestion, blinded samples, detector results, JSON reports, and visible HTML report tables
  • expands the dashboard fixture catalog and adds a researcher-facing fixture catalog document
  • adds compact golden scientific thresholds and a matched-null regression that cannot promote above the control evidence level
  • retains HTML, JSON, processed images, and candidate crops when CI analysis fails
  • bumps the package to v0.3.1

Why

Community review depends on knowing what each fixture is expected to demonstrate and on preventing detector changes from silently becoming more permissive. This patch makes fixture provenance auditable and puts conservative null behavior under CI protection.

Validation

  • python -m compileall laserlab gui tests scripts
  • python -m unittest discover -s tests (11 tests)
  • one-frame bundled fixture demo with source provenance verified in report.json
  • fixture catalog validates all required metadata and all bundled files
  • git diff --check

Closes #16
Closes #17

@ProhibitedTV
ProhibitedTV merged commit 525a458 into main Jul 10, 2026
2 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ce4a7a0451

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread laserlab/pipeline.py
"primary_metric_score": 0.0,
"q_value": None,
"persistence_score": 0.0,
"capture_metadata": sample.get("capture_metadata", {}),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve fixture metadata for generated controls

With the default control_generation setting, laser captures produce matched control samples via generate_matched_controls, but those records do not carry capture_metadata from the parent capture. As a result this newly added result field becomes {} for every generated control, so if a derived control is part of results.json or ranks as a top candidate, the fixture provenance is lost even though the parent laser capture had it.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Phase 7: Golden-run regression tests and CI artifacts Phase 7: Public fixture and footage catalog with licensing notes

1 participant