retry transient tunnel login failures on startup instead of exiting - #810
Open
kcoopermiller wants to merge 3 commits into
Open
retry transient tunnel login failures on startup instead of exiting#810kcoopermiller wants to merge 3 commits into
kcoopermiller wants to merge 3 commits into
Conversation
kcoopermiller
requested review from
DamianB-BitFlipper,
JannikSt,
JohannesHa,
burnpiro and
willccbb
as code owners
July 28, 2026 01:10
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the frpc config leaves loginFailExit at its default (true) and the SDK's startup watcher treats the first login to the server failed / connect to server error line in frpc output as fatal. So a single transient failure during tunnel startup kills frpc and the SDK then deletes the tunnel registration. Anything already holding that tunnel URL 404s permanently. This is one of the amplifiers behind the "404 Tunnel not found" errors
Note
Medium Risk
Changes core tunnel connect/cleanup behavior on startup; misclassified log lines could delay failure or abort too early, but scope is limited to prime-tunnel with solid test coverage.
Overview
Tunnel startup no longer tears down registration on the first transient frpc login/connect error, addressing a path where a brief network blip caused frpc to exit, the SDK to run cleanup (including deleting the tunnel), and clients to see permanent 404 Tunnel not found.
Generated frpc config now sets
loginFailExit = falseso frpc keeps retrying instead of exiting on the first login failure. Startup log handling uses_scan_startup_lineto treat "start proxy success" as connected, only fail fast when login/connect errors match known fatal server reasons (inactive tunnel, bad token/binding secret, etc.), and ignore other login/connect lines until success orconnection_timeout.Tests cover line classification, config output, riding out transient errors, fast-fail on rejections, and timeout on endless transient failures.
Reviewed by Cursor Bugbot for commit 71804a7. Bugbot is set up for automated code reviews on this repo. Configure here.