Skip to content

fix: stray java runtime tmps and version files - #724

Open
rozwader wants to merge 2 commits into
mainfrom
fix/stray-java-runtime-tmps
Open

fix: stray java runtime tmps and version files#724
rozwader wants to merge 2 commits into
mainfrom
fix/stray-java-runtime-tmps

Conversation

@rozwader

Copy link
Copy Markdown
Collaborator

Description

  1. Added removal of java runtime .tmp files after 10 minutes of their creation (probably user aborted installation and the file would sit forever in files). Code on launcher startup checks for .tmp files inside java directory and if a file is older than 10 minutes it deletes it.
  2. Added removal of java runtimes managed by OneClient when user decides to delete it. Previously they stayed in the files after user deleted them (they were only being deleted from the database).
  3. Added modal for removing java runtimes. User has to accept removal action.
  • If the java runtime is managed by OneClient it warns user that the files will be deleted
  • If the java runtime is managed by the user (files aren't in the OneClient java dir), only the database entry will be deleted

Related Issue(s)

#722

How to test

First feature

  1. Start downloading java runtime from any provider
  2. Exit the OneClient in the middle of installation
  3. Wait for 10 minutes
  4. Open up the folder where java runtime files are located in OneClient
  5. Boot up OneClient
  6. Files should delete in the same moment

Second feature

  1. Open up the folder where java runtime files are located in OneClient
  2. Boot up OneClient and go to the java settings
  3. Delete OneClient managed java runtime
  4. Given version will delete with the database entry

Third feature
1.1 Click delete button on OneClient managed java runtime
1.2 Modal will say that the files will be deleted and the button will be danger themed

2.1 Click delete button on user managed java runtime
2.2 Modal will say that the files won't be deleted and only a database entry will be removed

Documentation

No

…of being untouched; added removal of java runtime files whenever user deletes java runtime inside java settings (before they were only being deleted from the database, not files)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

2 participants