fix: model Minior meteor/core forms consistently

[MiquelRForgeFlow]

(Follow-up of #1616)

Give all 14 Minior forms is_battle_only=0 and a Shields Down condition whose base_form points to the same-colour counterpart (meteor <-> core), so the shield/core toggle is represented in both directions.

All 14 Minior forms (7 Meteor + 7 Core) are marked is_battle_only = 0, since neither is strictly battle-only: outside of battle a wild Minior appears in its Meteor form while a caught one shows its Core, so both forms can be seen outside of battle. The Shields Down toggle between them is instead captured by the trigger_conditions, with each form's base_form pointing to its same-colour counterpart (Meteor ↔ Core).

Which form is shown outside of battle (wild → Meteor, caught → Core) isn't something the current form model can express; it would need an extra configuration (a wild-vs-caught default form). That's out of scope here, but the same mechanism would also cover Gimmighoul (Chest vs Roaming), so it may be worth considering as a separate, follow-up feature.

AI coding assistance disclosure

Checking numbers and generating PR description.

Contributor check list

• I have written a description of the contribution and explained its motivation.
• I have written tests for my code changes (if applicable).
• I have read and understood the AI Assisted Contribution guidelines.
• I will own this change in production, and I am prepared to fix any bugs caused by my code change.

[jemarq04]

Its form is tied to its health by its ability, similar to Wishiwashi. I would say that the meteor forms are definitely their default forms for each color.

[MiquelRForgeFlow]

Its form is tied to its health by its ability, similar to Wishiwashi.

Yes, although Wishiwashi depends on level too.

I would say that the meteor forms are definitely their default forms for each color.

No. You can check wiki. Default wild form is meteor. Default captured form is core. BTW, meteor form (red) is still the default one.

[MiquelRForgeFlow]

similar to Wishiwashi

I checked it and saw that Wishiwashi was incomplete. Fixed in #1636.

[jemarq04]

No. You can check wiki. Default wild form is meteor. Default captured form is core. BTW, meteor form (red) is still the default one.

I’m not sure what you mean by default captured form. Is it the form it takes when I send it out in battle? Or is it just the sprite in the PC? If it’s the latter, then we don’t distinguish that and meteor should be default.

Since this pokemon has many different meteor forms, all of which are equally valid, the meteor forms should be left as default.

[MiquelRForgeFlow]

I’m not sure what you mean by default captured form. Is it the form it takes when I send it out in battle? Or is it just the sprite in the PC? If it’s the latter, then we don’t distinguish that and meteor should be default.

By "wild form" I mean when you find the pokemon in the wild (they appear in meteor form), and by "captured form" I mean by how they appear outside of battle, for example in PC (they appear in core form).

Since this pokemon has many different meteor forms, all of which are equally valid, the meteor forms should be left as default.

Yes, that doesn't change in my PR. No default is changed here. Meteor form is still the default one, also because it's the one that it have when it has full HP in battle, so it makes sense to be this one. My PR only avoids marking as battle-only any of these forms and also makes the ability trigger exists in all the forms.

BTW, the default one is the red meteor form. Not sure if we should also mark as default the other colored meteor forms.

[jemarq04]

Ah, ok I had misread your PR I believe. I understand now, sorry for the confusion!

Sync this with master and I’ll do a quick review when I can