Skip to content

fix: set base_form for Rockruff → Lycanroc evolutions - #1617

Merged
Naramsim merged 1 commit into
PokeAPI:masterfrom
MiquelRForgeFlow:master-fix-rockruff-own-tempo-dusk-lycanroc
Jul 26, 2026
Merged

fix: set base_form for Rockruff → Lycanroc evolutions#1617
Naramsim merged 1 commit into
PokeAPI:masterfrom
MiquelRForgeFlow:master-fix-rockruff-own-tempo-dusk-lycanroc

Conversation

@MiquelRForgeFlow

Copy link
Copy Markdown
Contributor

Change description

Rockruff's three Lycanroc evolutions had an empty base_form_id, so the API reported no form dependency and every Lycanroc form looked reachable from any Rockruff. Set base_form to match the games:

  • Dusk (row 460) ← Own Tempo Rockruff (10151)
  • Midday (row 386) ← default Rockruff (744)
  • Midnight (row 387) ← default Rockruff (744)

AI coding assistance disclosure

Only used AI for checking numbers, columns and write PR description.

Contributor check list

  • I have written a description of the contribution and explained its motivation.
  • I have written tests for my code changes (if applicable).
  • I have read and understood the AI Assisted Contribution guidelines.
  • I will own this change in production, and I am prepared to fix any bugs caused by my code change.

@MiquelRForgeFlow

Copy link
Copy Markdown
Contributor Author

@Naramsim

@jemarq04

Copy link
Copy Markdown
Member

Good catch! Can't a Rockruff with Own Tempo evolve into the other forms though so long as it levels up during Day/Night? Or is it locked to Dusk form?

@MiquelRForgeFlow

Copy link
Copy Markdown
Contributor Author

It's in the wiki: Selection_6184

@jemarq04

Copy link
Copy Markdown
Member

Ah ok, I didn't know that! Looks good to me then. And in the future, no need to ping us to take a look, we'll get to PRs when we can

@Naramsim
Naramsim merged commit 7fe6801 into PokeAPI:master Jul 26, 2026
19 checks passed
@Naramsim

Copy link
Copy Markdown
Member

Thank you, sorry for keeping you waiting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants