Skip to content

Show the critical-alert notice on the signup form #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
RisingOrange wants to merge 7 commits into
base: main
Choose a base branch
from
+13 −8
Draft

Show the critical-alert notice on the signup form #1010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bc0ab8e
feat(onboarding): show the critical-alert notice on the email field
RisingOrange Jul 29, 2026
1af2826
fix(onboarding): restore the modal "may" in the German notice
RisingOrange Jul 30, 2026
c47dd93
fix(onboarding): move the notice to the intent step and drop "else"
RisingOrange Jul 30, 2026
67c6048
fix(onboarding): idiomatic German for the critical-alert notice
RisingOrange Jul 30, 2026
78414a7
fix(onboarding): tutoiement and idiomatic French for the notice
RisingOrange Jul 30, 2026
bbb880f
fix(onboarding): name what the German clause refers to
RisingOrange Jul 30, 2026
a11b56f
a11y(onboarding): associate the notice with the opt-in controls
RisingOrange Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions src/lib/components/onboarding/OnboardingFlow.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,10 +422,6 @@
autocomplete="email"
bind:value={basics.email}
/>
<!-- <p class="helper">
We may contact you about critical mobilizations, see our
<Link href="/privacy">privacy policy</Link>.
</p> -->
</div>
<div class="field">
<label class="field-label" for="ob-country">{msgs.onboarding_field_country}</label>
Expand Down Expand Up @@ -483,6 +479,7 @@
class="intent-option"
class:selected={keepInformed}
role="checkbox"
aria-describedby="critical-alert-notice"
aria-checked={keepInformed}
onclick={() => (keepInformed = !keepInformed)}
>
Expand All @@ -502,6 +499,7 @@
class="intent-option"
class:selected={basics.newsletter}
role="checkbox"
aria-describedby="critical-alert-notice"
aria-checked={basics.newsletter}
onclick={() => (basics.newsletter = !basics.newsletter)}
>
Expand All @@ -517,6 +515,10 @@
</span>
</button>
</div>
<p class="helper" id="critical-alert-notice">
<!-- eslint-disable-next-line svelte/no-at-html-tags -->
{@html msgs.onboarding_email_critical_notice}
</p>
<p class="section-label">{msgs.onboarding_intent_more_optional}</p>
<div class="intent-stack" role="radiogroup" aria-label="Want to do more?">
{#each intentOptions as option (option.key)}
Expand Down Expand Up @@ -621,10 +623,6 @@
autocomplete="email"
bind:value={basics.email}
/>
<!-- <p class="helper">
We may contact you about critical mobilizations, see our
<Link href="/privacy">privacy policy</Link>.
</p> -->
</div>
<div class="field">
<label class="field-label" for="loop-country">{msgs.onboarding_field_country}</label
Expand Down
7 changes: 7 additions & 0 deletions src/lib/components/onboarding/messages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ export interface OnboardingMessages {
onboarding_placeholder_full_name: string
onboarding_field_email: string
onboarding_placeholder_email: string
onboarding_email_critical_notice: string
onboarding_field_country: string
onboarding_placeholder_country: string
onboarding_field_city: string
Expand Down Expand Up @@ -188,6 +189,8 @@ const en: OnboardingMessages = {
onboarding_placeholder_full_name: 'Full name',
onboarding_field_email: 'Email *',
onboarding_placeholder_email: 'Email',
onboarding_email_critical_notice:
'We may occasionally send you a critical alert, even if you don\'t opt into any of these. See our <a target="_blank" rel="noopener noreferrer" href="/privacy">privacy policy</a>.',
onboarding_field_country: 'Country of residence *',
onboarding_placeholder_country: 'Select your country',
onboarding_field_city: 'City / town of residence *',
Expand Down Expand Up @@ -398,6 +401,8 @@ const de: OnboardingMessages = {
onboarding_placeholder_full_name: 'Vollständiger Name',
onboarding_field_email: 'E-Mail *',
onboarding_placeholder_email: 'E-Mail',
onboarding_email_critical_notice:
'In dringenden Fällen könnten wir dir eine Nachricht senden, auch wenn du keine dieser Optionen wählst. Siehe unsere <a target="_blank" rel="noopener noreferrer" href="/privacy">Datenschutzrichtlinie</a>.',
onboarding_field_country: 'Wohnsitzland *',
onboarding_placeholder_country: 'Land auswählen',
onboarding_field_city: 'Stadt / Gemeinde *',
Expand Down Expand Up @@ -618,6 +623,8 @@ const fr: OnboardingMessages = {
onboarding_placeholder_full_name: 'Nom complet',
onboarding_field_email: 'E-mail *',
onboarding_placeholder_email: 'E-mail',
onboarding_email_critical_notice:
'Nous pouvons occasionnellement t\'envoyer une alerte urgente, même si tu ne sélectionnes aucune de ces options. Consulte notre <a target="_blank" rel="noopener noreferrer" href="/privacy">politique de confidentialité</a>.',
onboarding_field_country: 'Pays de résidence *',
onboarding_placeholder_country: 'Sélectionne ton pays',
onboarding_field_city: 'Ville / commune de résidence *',
Expand Down
Loading