fix(ui): live speed/online indicators lost in #88 squash merge - #98
Open
leonidorlov-hash wants to merge 2 commits into
Open
fix(ui): live speed/online indicators lost in #88 squash merge#98leonidorlov-hash wants to merge 2 commits into
leonidorlov-hash wants to merge 2 commits into
Conversation
…squash merge The squash merge of PRVTPRO#88 kept the helpers (parseHandshakeAgo, formatHandshakeCompact, computeRates) and the CSS (.meta-online, .speed-badge, .avatar-online), but the render loop never called them, so the online pulse, compact handshake and live speed badge never appeared. This wires the render loop back to the helpers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Проблема
При squash-мерже #88 в
mainпопали хелперы (parseHandshakeAgo,formatHandshakeCompact,computeRates) и CSS (.meta-online,.speed-badge,.avatar-online), но цикл рендера их не вызывает:_online = trueне выставляется нигде, бейдж скорости не создаётся, handshake показывается длинной строкой.Итог: пульсирующей точки онлайна и живой скорости в v1.6.0 нет, хотя весь код для них лежит мёртвым грузом.
Решение
Возвращаю вызовы в цикл рендера — ровно то, что было в оригинальном #88:
🤝в компактном виде (2h 29m ago) с классомmeta-onlineпри handshake < 3 мин;client._online = true→ зелёная пульсирующая точка на аватаре;↓X/s ↑Y/sиз дельт счётчиков между опросами.