Pacify PPJ teething problems - #36
Open
XxX-Daniil-underscore-Zaikin-XxX wants to merge 13 commits into
Open
Conversation
XxX-Daniil-underscore-Zaikin-XxX
marked this pull request as draft
June 19, 2024 06:22
…to true, as all other strict checks are disabled by default
Contributor
Author
|
I think this PR is pretty much done. If I find anything else to change, I can probably just make another one. |
XxX-Daniil-underscore-Zaikin-XxX
marked this pull request as ready for review
June 4, 2025 11:00
XxX-Daniil-underscore-Zaikin-XxX
marked this pull request as draft
June 4, 2025 11:15
Contributor
Author
|
never mind, I have yet to make sure GH actions works. |
Contributor
Author
|
never mind? Looks like CI just worked first try. |
XxX-Daniil-underscore-Zaikin-XxX
marked this pull request as ready for review
June 4, 2025 12:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've encountered a couple of issues when trying to use PPJ files. This is an attempt to fix them.
So far, this PR:
scriptnamedeclarationskyrim-allow-unknown-event...option to align with the other Strict checks (i.e. disabled by default).