Add Drivers board to pause menu - #136
Merged
Merged
Conversation
Adds a 'Drivers board' menu item to the pause menu (PauseMenuState), sitting between Settings and Abandon job. The handler lazily imports and pushes DriversOnlineState, identical to the path in OnlineHubState. Viewing the board shares nothing about the paused driver. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…pause-menu # Conflicts: # CHANGELOG.md
Owner
|
Thanks wleicht -- merging this one. Heads up for next time: the 1.8 line is in maintenance until 1.9 preview snapshots begin, so feature PRs are normally being held (see "What Is Being Accepted Right Now" in CONTRIBUTING.md). That policy only went in yesterday and the note lives in an HTML comment in the PR template, which is easy to miss. This one is small, self-contained, and reuses the state the Online hub already pushes, so it goes in as-is. I merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
Added a
Drivers boarditem toPauseMenuStateindriving_menu_states.py. The item sits betweenSettingsandAbandon jobin the pause menu and pushesDriversOnlineState-- the same path the Online hub already takes. No credential or account check is needed, because viewing the board shares nothing.What players or maintainers will notice
A new Drivers board entry appears in the pause menu between Settings and Abandon job. Selecting it opens the same live drivers board screen available from the main menu's Online section, letting a player check who is hauling without quitting the drive.
Tests and checks run
uv run ruff check src tests tools-- all checks passeduv run pytest-- full suite passed (exit code 0)Accessibility impact
The new item is a standard
MenuItemwith a plain spoken label and help text consistent with the rest of the menu. Its help text reads: "Hear who is hauling right now on the public orinks.net drivers board. Viewing the board shares nothing about you." Keyboard and screen-reader flow is unchanged for all existing items. Visually there is no UI.Changelog
## UnreleasedinCHANGELOG.md, written in plain player language and matching the style of the existing entries.