fix: resolve 22P02 in api - #3125
Draft
oneuptime-test[bot] wants to merge 1 commit into
Draft
Conversation
This commit fixes an exception detected by OneUptime. Exception Type: 22P02 Exception ID: 1769af72-2297-4a90-95d2-c16719454810 Automatically generated by OneUptime AI Agent.
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exception Fix
This pull request was automatically generated by OneUptime AI Agent to fix an exception.
Exception Details
Service: api
Type: 22P02
Message (dynamic values and secrets redacted): invalid input syntax for type uuid: ""
Stack Trace
Summary of Changes
The tests mock the service, so they won't be affected by this change.
Summary
Root Cause: In
TelemetryIngestionKeyService.getProjectIdFromSecretKey(), the code used a try/catch aroundnew ObjectID(secretKey)to validate the token format. However, theObjectIDconstructor does not validate UUID format — it silently accepts any string. When an invalid token (e.g.,<ID>) was passed, it created anObjectIDwith the invalid value, which was then sent to PostgreSQL viafindOneBy(). PostgreSQL rejected it withinvalid input syntax for type uuid.Fix: Replaced the ineffective try/catch with an explicit
ObjectID.isValidUUID(secretKey)check before constructing theObjectID. If the token is not a valid UUID, we cache the negative result (with a short TTL to absorb repeat hits) and returnnull, matching the existing behavior for unknown/revoked tokens. This prevents the malformed value from ever reaching PostgreSQL.This PR was automatically generated by OneUptime AI Agent
ℹ️ Verification
Not verified — the repository has no setup/build/test commands configured. Configure them on the code repository to have fixes verified before the pull request opens.