Skip to content

Fix monitor timeline no-data states - #2944

Draft
simlarsen wants to merge 1 commit into
masterfrom
agent/fix-monitor-timeline-disabled-no-data
Draft

Fix monitor timeline no-data states#2944
simlarsen wants to merge 1 commit into
masterfrom
agent/fix-monitor-timeline-disabled-no-data

Conversation

@simlarsen

Copy link
Copy Markdown
Contributor

Summary

  • render days with no monitoring coverage as neutral gray instead of healthy green, using half-open millisecond-precise day boundaries
  • persist no-data gaps when monitors are directly disabled and safely resume their current status when re-enabled
  • serialize bulk/single monitor transitions and recover failed hooks, late status writes, rapid toggles, and rolling-deploy writes from older pods
  • repair existing timeline drift with a restartable data migration plus a bounded startup/hourly safety reconciler

Root cause

The Dashboard passed healthy green as its empty-day fallback, while disabling a monitor left the latest status timeline row open. Open rows are extended to the present, so disabled or otherwise unobserved time appeared healthy.

Testing

  • npm run fix
  • cd Common && npm run compile
  • cd App && npm run compile
  • cd App/FeatureSet/Dashboard && npm run compile
  • 91 new regression tests covering day classification, half-open and exact-ms boundaries, pause/resume lifecycle, per-monitor locking, retries, failure recovery, old-pod races, late status writes, orphan protection, migration repair, pagination, and bounded recurring reconciliation
  • 120 relevant checks passed (114 Common + 6 App)

Fixes #576

@simlarsen

Copy link
Copy Markdown
Contributor Author

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI/UX: New Monitors Have A Really Good Uptime /s

2 participants