Skip to content

CIS-3773 Update workflows - #57

Merged
saligiad merged 1 commit into
mainfrom
CIS-3773
Jun 25, 2026
Merged

CIS-3773 Update workflows#57
saligiad merged 1 commit into
mainfrom
CIS-3773

Conversation

@saligiad

Copy link
Copy Markdown
Contributor

Overview

Update existing workflows to use the organization's shared workflows:

  • build.yaml
  • dependabot-changelog-update.yaml
  • release.yaml

Additionally, split the build workflow into separate publication and testing workflows, so that PRs can run the test build without needed secrets. Also, refined the build trigger rules to reduce redundant workflow runs.

Issues

CIS-3773

[x] Added to CHANGELOG.md

Update existing workflows to use the organization's shared workflows:

* build.yaml
* dependabot-changelog-update.yaml
* release.yaml

Additionally, split the build workflow into separate publication and
testing workflows, so that PRs can run the test build without needed
secrets. Also, refined the build trigger rules to reduce redundant
workflow runs.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main difference I noticed between this and the shared build workflow is that the shared workflow includes a step to upload the JAR file to build the container, but that seems to be skipped by the conditional check:

      - name: Upload application JAR for container build
 ->     if: vars.APP_JAR_NAME != ''
        uses: actions/upload-artifact@v7
        with:
          ...

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the application repositories have additional variables for the container workflow (see webhook forwarder's settings for an example). If the variable isn't defined the upload is skipped.

@saligiad
saligiad marked this pull request as ready for review June 25, 2026 22:07
@saligiad
saligiad requested a review from heathharrelson June 25, 2026 22:07
# - reopened
# - ready_for_review
# - labeled
# - unlabeled

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the change that I subsequently reverted, so you don't need to replicate it in the other repos. It's harmless because the workflow is disabled, and we'll probably just be deleting it.

@saligiad
saligiad merged commit ab39f64 into main Jun 25, 2026
2 checks passed
@saligiad
saligiad deleted the CIS-3773 branch June 25, 2026 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants