Skip to content

lsof: 4.94.0 -> 4.95.0 - #179945

Merged
trofi merged 1 commit into
NixOS:stagingfrom
trofi:update-lsof
Jul 5, 2022
Merged

lsof: 4.94.0 -> 4.95.0#179945
trofi merged 1 commit into
NixOS:stagingfrom
trofi:update-lsof

Conversation

@trofi

@trofi trofi commented Jul 2, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor
Description of changes

Changes: https://github.com/lsof-org/lsof/releases/tag/4.95.0

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg
ofborg Bot requested a review from dezgeg July 2, 2022 20:28
@ofborg ofborg Bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Jul 2, 2022
@wentasah

wentasah commented Jul 5, 2022

Copy link
Copy Markdown
Contributor

LGTM. I built it and tested by simple lsof invocations. Upstream changelog mentions removal of LSOF_CCDATE so the change in no-build-info.patch makes sense.

@trofi
trofi merged commit 7b4e8ea into NixOS:staging Jul 5, 2022
@trofi
trofi deleted the update-lsof branch July 5, 2022 11:33
@jiegec

jiegec commented Jul 14, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

It is failing on hydra: https://hydra.nixos.org/build/183734819.

See lsof-org/lsof#226 and lsof-org/lsof#233 for fixes of libproc backend.

@trofi

trofi commented Jul 14, 2022

Copy link
Copy Markdown
Contributor Author

The failure probably started with #110571. I partially fixed it in #177141, but I had no chance to build-test it on darwin.

If you have access to darwin can you write a similar PR against nixpkgs's staging-next that pulls in your pending patches into lsof?

@jiegec

jiegec commented Jul 14, 2022

Copy link
Copy Markdown
Member

The failure probably started with #110571. I partially fixed it in #177141, but I had no chance to build-test it on darwin.

If you have access to darwin can you write a similar PR against nixpkgs's staging-next that pulls in your pending patches into lsof?

Sure.

@jiegec jiegec mentioned this pull request Jul 15, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dezgeg dezgeg Awaiting requested review from dezgeg

Assignees

No one assigned

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@trofi @wentasah @jiegec