Skip to content

sil-q: init at 1.5.0 - #177331

Merged
SuperSandro2000 merged 2 commits into
NixOS:masterfrom
kenranunderscore:add-sil-q
Jun 14, 2022
Merged

sil-q: init at 1.5.0#177331
SuperSandro2000 merged 2 commits into
NixOS:masterfrom
kenranunderscore:add-sil-q

Conversation

@kenranunderscore

Copy link
Copy Markdown
Contributor
Description of changes

Adds the Sil-Q game, with support for the ncurses and X11 frontends. Sil-Q is the "continuation" of Sil (which is already packaged but no longer actively developed).

The Nix expression takes some things from Sil's and is thus quite similar. One thing I don't know yet is whether I need the NIX_CFLAGS_COMPILE = "-fcommon" bit, too. It seems to be relevant to #110571.

This also adds me as a maintainer as a separate commit as per the manual.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg Bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 11, 2022
@necrophcodr

necrophcodr commented Jun 12, 2022

Copy link
Copy Markdown
Contributor

I've tried running this using nix run and it may be ideal to add mainProgram = "sil" as well (please see https://nixos.org/manual/nix/unstable/command-ref/new-cli/nix3-run.html#description for more unformation on this). Additionally, when running it after building it, it simply produces the following message:

./result/bin/sil: Cannot create the '~/.sil/apex/scores.raw' file!

The 'lib' directory is probably missing or broken.
Perhaps the archive was not extracted correctly.
See the manual for more information.

Am I missing something here?

@kenranunderscore

kenranunderscore commented Jun 12, 2022

Copy link
Copy Markdown
Contributor Author

I've tried running this using nix run and it may be ideal to add mainProgram = "sil" as well (please see https://nixos.org/manual/nix/unstable/command-ref/new-cli/nix3-run.html#description for more unformation on this).

Thanks, fixed that! I didn't try it with nix run and it's something I'll do in the future for sure.

Additionally, when running it after building it, it simply produces the following message:

./result/bin/sil: Cannot create the '~/.sil/apex/scores.raw' file!

The 'lib' directory is probably missing or broken.
Perhaps the archive was not extracted correctly.
See the manual for more information.

Am I missing something here?

No you're not. I have introduced that by replacing --run ... with a --set ... in the wrapProgram call, and it has worked on my machine because I already had the directory from tests before that, sorry. The ~/.sil was in single quotes in the wrapper script, so no shell expansion took place. Should be fixed now as well. Thanks for trying it out!

Edit: @necrophcodr In my mails I saw another comment of yours regarding install. I guess that's been deleted, or am I looking int the wrong place?

Comment thread pkgs/games/sil-q/default.nix Outdated
Comment thread pkgs/games/sil-q/default.nix Outdated
Comment thread pkgs/games/sil-q/default.nix Outdated
Comment thread pkgs/games/sil-q/default.nix Outdated
Comment thread pkgs/games/sil-q/default.nix Outdated
Comment thread maintainers/maintainer-list.nix Outdated
@kenranunderscore
kenranunderscore force-pushed the add-sil-q branch 2 times, most recently from 60005f5 to ff57f9c Compare June 13, 2022 11:37
@kenranunderscore kenranunderscore mentioned this pull request Jun 13, 2022
13 tasks
kenranunderscore and others added 2 commits June 13, 2022 23:07
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@SuperSandro2000 SuperSandro2000 changed the title sil-q: init at v1.5.0 sil-q: init at 1.5.0 Jun 14, 2022
@SuperSandro2000
SuperSandro2000 merged commit f600a0d into NixOS:master Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants