[Tile] Disable execution checks in some tuple / pair helpers - #10712
Conversation
We are explicitly using ADL found functions which might not support all execution spaces
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe change adds explicit constexpr special members to iterator and compressed storage types. It also applies execution-check suppression annotations to tuple operations, delegated constructors, and pair swap functions. ChangesExecution Check Updates
Possibly related PRs
Suggested reviewers: Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
libcudacxx/include/cuda/__iterator/constant_iterator.h (1)
113-120: 🎯 Functional Correctness | 🔵 Trivialsuggestion: Run the relevant CCCL CMake preset, targeted host/device/NVRTC tests, and
pre-commit run --all-files. Report the results before merge because this change affects synthesized special members and execution-check handling.As per coding guidelines, use the provided CMake presets and targeted build/test targets, run pre-commit checks, and report the results.
Source: Coding guidelines
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 4389edbe-bd6f-472b-804b-84ec20d1e38f
📒 Files selected for processing (6)
libcudacxx/include/cuda/__iterator/constant_iterator.hlibcudacxx/include/cuda/std/__ranges/compressed_movable_box.hlibcudacxx/include/cuda/std/__tuple_dir/tuple.hlibcudacxx/include/cuda/std/__tuple_dir/tuple_leaf.hlibcudacxx/include/cuda/std/__utility/delegate_constructors.hlibcudacxx/include/cuda/std/__utility/pair.h
⏱️ CCCL compile-time benchmark comparison: Public headers compile-time benchResult: 0 regression row(s), 7 improvement row(s) above threshold.
Artifacts: reports and traces Direct file processing
🟢 Direct file processing — Improvements
|
🥳 CI Workflow Results🟩 Finished in 3h 59m: Pass: 100%/115 | Total: 5d 18h | Max: 3h 58m | Hits: 38%/2163584See results here. |
Those were missed, because the use the ADL found overloads.
There are some additional warnings popping up from synthesized constructors, so disable them as well