[cudax][cuco] Migrate rebind APIs for fixed_capacity_map_ref - #10695
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
/ok to test ec054ac |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughSummary by CodeRabbit
WalkthroughAdded Changesfixed_capacity_map rebinding
Assessment against linked issues
Possibly related PRs
Suggested reviewers: Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 4693319a-ae3b-4d9a-a5d7-ab6c247fe7d1
📒 Files selected for processing (3)
cudax/include/cuda/experimental/__cuco/fixed_capacity_map_ref.cuhcudax/test/CMakeLists.txtcudax/test/cuco/fixed_capacity_map/test_rebind.cu
| cudax_add_catch2_test(test_target cuco.fixed_capacity_map.rebind ${cudax_target} | ||
| cuco/fixed_capacity_map/test_rebind.cu | ||
| ) |
There was a problem hiding this comment.
Nit (for a follow up PR): I noticed there are a few of these tests reach into/several/subdirectories to get the tests. Consider doing add_subdirectory() instead at each level. It makes no meaningful difference, but it just feels more organized.
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
⏱️ CCCL compile-time benchmark comparison: Public headers compile-time benchResult: 0 regression row(s), 2 improvement row(s) above threshold.
Artifacts: reports and traces Direct file processing
🟢 Direct file processing — Improvements
|
🥳 CI Workflow Results🟩 Finished in 1h 33m: Pass: 100%/63 | Total: 1d 19h | Max: 1h 07m | Hits: 13%/348732See results here. AI failure analysis1. First downstream failure unavailable for cudf matrix · 1 jobExplanation: The RAPIDS matrix containing kvikio, rapidsmpf, cudf, and cudf_kafka failed in step 6, but no job log was collected. The workflow exits on the first failed library, so neither the failing library nor its diagnostic can be determined from the manifest alone. Root cause: Unknown because `job-93862028342.log` is missing. The available evidence cannot distinguish a CCCL compatibility regression from a downstream dependency, container, network, or compiler failure. Sources: .github/workflows/build-rapids.yml:66, .github/workflows/build-rapids.yml:157. Suggested next steps: Retrieve the missing job log or reproduce with `RAPIDS_LIBS='rmm ucxx kvikio rapidsmpf cudf cudf_kafka' .devcontainer/launch.sh -d -c 13.3 -H rapids-conda -- ./ci/rapids/rapids-entrypoint.sh /bin/bash -li -c 'uninstall-all -j -qqq && clean-all -j && build-all -j0 -v'`. Diagnose the first configure or compiler error rather than the final exit status. Copy this prompt into a coding agentJobs: 2. First downstream failure unavailable for cuml matrix · 1 jobExplanation: The RAPIDS matrix containing raft, cuvs, nvforest, and cuml failed in step 6, but its job log is absent. Because the script stops at the first failed library, the manifest does not identify which package or command failed. Root cause: Unknown because `job-93862028572.log` is missing. There is insufficient evidence to group this with either other RAPIDS failure despite their shared rmm and ucxx prefixes. Sources: .github/workflows/build-rapids.yml:67, .github/workflows/build-rapids.yml:157. Suggested next steps: Retrieve the missing job log or reproduce with `RAPIDS_LIBS='rmm ucxx raft cuvs nvforest cuml' .devcontainer/launch.sh -d -c 13.3 -H rapids-conda -- ./ci/rapids/rapids-entrypoint.sh /bin/bash -li -c 'uninstall-all -j -qqq && clean-all -j && build-all -j0 -v'`. Use the first package-specific diagnostic to determine whether this shares a fix with another matrix. Copy this prompt into a coding agentJobs: 3. First downstream failure unavailable for cugraph matrix · 1 jobExplanation: The RAPIDS matrix containing raft, cuvs, cugraph, and wholegraph failed in step 6 without an available job log. The workflow's fail-fast package loop leaves no reliable failure signature in `jobs.json`. Root cause: Unknown because `job-93862028555.log` is missing. Similar timing, step number, and shared dependencies are not sufficient to establish the same causal mechanism as the other matrices. Sources: .github/workflows/build-rapids.yml:68, .github/workflows/build-rapids.yml:157. Suggested next steps: Retrieve the missing job log or reproduce with `RAPIDS_LIBS='rmm ucxx raft cuvs cugraph wholegraph' .devcontainer/launch.sh -d -c 13.3 -H rapids-conda -- ./ci/rapids/rapids-entrypoint.sh /bin/bash -li -c 'uninstall-all -j -qqq && clean-all -j && build-all -j0 -v'`. Compare the earliest diagnostic with the cuml matrix before combining remediation. Copy this prompt into a coding agentJobs: |
Description
closes #10646
This PR migrates the rebind APIs from
cuco::static_map_reftocudax::cuco::fixed_capacity_map_refand adds corresponding tests.Checklist