Pretty printers maintenance - #10686
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughSummary by CodeRabbit
WalkthroughPretty-printer implementations now handle reference-valued CUDA types in GDB and LLDB. Debugger tests use optimized builds, simplified case arguments, shorter timeouts, and expanded output normalization. ChangesDebugger case execution and build configuration
Possibly related PRs
Suggested reviewers: Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
libcudacxx/test/debugging/CMakeLists.txt (1)
165-168: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winsuggestion: Update the helper documentation for the new build mode.
The documentation for
libcudacxx_add_pretty_printer_teststill says that targets have host debug information and disabled optimization. The implementation now requests-O3andNDEBUG, and removes explicit-g. Update that contract after restoring debug information. (raw.githubusercontent.com)Source: MCP tools
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 7b8d6e00-ac46-4d8c-a952-ac04b6fa0a24
📒 Files selected for processing (1)
libcudacxx/test/debugging/CMakeLists.txt
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
libcudacxx/test/debugging/run_pretty_printer_test.py (1)
528-530: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winsuggestion: Add regression tests for
> > >, quoted text containing42u, addresses, and suffixed integers. Run the targeted pretty-printer test with the repository CMake/Ninja preset and runpre-commit run --all-filesbefore merge.As per path instructions, files under
libcudacxx/testfollow.agent/skills/cccl-test/SKILL.md, and changes require targeted validation and pre-commit checks.Source: Path instructions
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 055a8252-208d-4627-b6ff-b77c39e5d8c6
📒 Files selected for processing (1)
libcudacxx/test/debugging/run_pretty_printer_test.py
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
88fc073 to
5ffd62b
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 3542af87-4774-4126-884a-e537f0257eb2
📒 Files selected for processing (42)
libcudacxx/share/libcudacxx/gdb/atomic.pylibcudacxx/share/libcudacxx/gdb/buffer.pylibcudacxx/share/libcudacxx/gdb/complex.pylibcudacxx/share/libcudacxx/gdb/event.pylibcudacxx/share/libcudacxx/gdb/inplace_vector.pylibcudacxx/share/libcudacxx/gdb/memory_resource.pylibcudacxx/share/libcudacxx/gdb/std_array.pylibcudacxx/share/libcudacxx/gdb/tuple.pylibcudacxx/share/libcudacxx/lldb/atomic.pylibcudacxx/share/libcudacxx/lldb/buffer.pylibcudacxx/share/libcudacxx/lldb/complex.pylibcudacxx/share/libcudacxx/lldb/event.pylibcudacxx/share/libcudacxx/lldb/inplace_vector.pylibcudacxx/share/libcudacxx/lldb/memory_resource.pylibcudacxx/share/libcudacxx/lldb/std_array.pylibcudacxx/share/libcudacxx/lldb/tuple.pylibcudacxx/test/debugging/CMakeLists.txtlibcudacxx/test/debugging/array/CMakeLists.txtlibcudacxx/test/debugging/array/lldb.expectedlibcudacxx/test/debugging/array/source.culibcudacxx/test/debugging/atomic/CMakeLists.txtlibcudacxx/test/debugging/atomic/lldb.expectedlibcudacxx/test/debugging/atomic/source.culibcudacxx/test/debugging/buffer/CMakeLists.txtlibcudacxx/test/debugging/buffer/lldb.expectedlibcudacxx/test/debugging/buffer/source.culibcudacxx/test/debugging/complex/CMakeLists.txtlibcudacxx/test/debugging/complex/lldb.expectedlibcudacxx/test/debugging/complex/source.culibcudacxx/test/debugging/event/CMakeLists.txtlibcudacxx/test/debugging/event/lldb.expectedlibcudacxx/test/debugging/event/source.culibcudacxx/test/debugging/inplace_vector/CMakeLists.txtlibcudacxx/test/debugging/inplace_vector/lldb.expectedlibcudacxx/test/debugging/inplace_vector/source.culibcudacxx/test/debugging/memory_resource/CMakeLists.txtlibcudacxx/test/debugging/memory_resource/lldb.expectedlibcudacxx/test/debugging/memory_resource/source.culibcudacxx/test/debugging/run_pretty_printer_test.pylibcudacxx/test/debugging/tuple/CMakeLists.txtlibcudacxx/test/debugging/tuple/lldb.expectedlibcudacxx/test/debugging/tuple/source.cu
🚧 Files skipped from review as they are similar to previous changes (1)
- libcudacxx/test/debugging/CMakeLists.txt
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
… up a frame to print things
…e going up a frame to print things
…e going up a frame to print things
18fd5f8 to
7444848
Compare
⏱️ CCCL compile-time benchmark comparison: Public headers compile-time benchResult: 6 regression row(s), 2 improvement row(s) above threshold.
Artifacts: reports and traces Direct file processing
🔴 Direct file processing — Regressions
🟢 Direct file processing — Improvements
|
🥳 CI Workflow Results🟩 Finished in 2h 24m: Pass: 100%/68 | Total: 1d 02h | Max: 57m 54s | Hits: 98%/306720See results here. AI failure analysis1. Merged RAPIDS environment requests incompatible rapids-logger versions · 1 jobExplanation: The RAPIDS build stops before compilation because its generated Conda environment simultaneously requires rapids-logger 0.2.x and 0.3.x. The PR's debugger changes are not reached or implicated by the failure. Evidence: Build RAPIDS (optional) / rmm ucxx kvikio rapidsmpf cudf cudf_kafka, step 6 Root cause: Dependency files from the selected main-branch RAPIDS repositories were merged into one environment while different repositories required mutually exclusive rapids-logger minor versions. The log does not retain enough attribution to determine which generated per-repository environment supplied each constraint. Sources: .github/workflows/build-rapids.yml:66, ci/rapids/post-create-command.sh:38, ci/rapids/cuda13.3-conda/devcontainer.json:90. Suggested next steps: Inspect the generated per-repository Conda YAML files to identify the sources of the 0.2.x and 0.3.x constraints, then align those downstream dependencies or temporarily pin the affected RAPIDS repository to a compatible commit. Reproduce narrowly with `RAPIDS_LIBS='rmm ucxx kvikio rapidsmpf cudf cudf_kafka' .devcontainer/launch.sh -d -c 13.3 -H rapids-conda -- ./ci/rapids/rapids-entrypoint.sh /bin/bash -li -c 'build-all -j0 -v'`. Copy this prompt into a coding agentJobs: |
Description
asm()callChecklist