demos: standalone system-services-monitor demo - #1383
Draft
dmvevents wants to merge 3 commits into
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
6 tasks
Contributor
|
@dmvevents this PR has been inactive for 14 days. Do you need help finishing it, or should we close it for now? Feel free to reopen anytime. |
Lands the demo subtree (NVIDIA#891 split, 5 of 5). Standalone — depends on the implementation in <impl-pr-num> but doesn't gate any production functionality. Includes CR-ignored fixes from the umbrella PR: - daemonset.yaml: image pinned to SHA tag (not :0.1.0) - daemonset.yaml: livenessProbe httpGet validated - servicemonitor.yaml: FabricManagerFlapping alert spec - Dockerfile: python:3.13 base for CVE remediation Signed-off-by: Anton Alexander <dmvevents@users.noreply.github.com>
…validation The demo re-bundled CUDA context/memory validation as a polling daemon check — the exact model deesharma24 rejected on NVIDIA#891, where a long-running daemon contends for GPU memory with active workloads. That review is why CUDA validation re-landed as a preflight init-container (NVIDIA#1384), which runs once before workloads schedule. Remove the daemon check from this demo to avoid contradicting the accepted design: delete checks/cuda_validation.py and drop all references from monitor.py, config.py, metrics.py, the k8s ConfigMap/PrometheusRule, and the tests. README now points at preflight-checks/cuda-validation/ (NVIDIA#1384) as the supported form. Also note in the DaemonSet that the system-services-monitor:0.1.0 tag is a demo-local pin, independent of the Helm chart appVersion. Signed-off-by: Anton Alexander <dmvevents@users.noreply.github.com>
The system-services-monitor design doc is ADR-049; ADR-030 upstream is the unrelated grpc-tls-authentication design. Corrects the scope docstring only. Signed-off-by: Anton Alexander <dmvevents@users.noreply.github.com>
dmvevents
force-pushed
the
demo-system-services-monitor
branch
from
July 24, 2026 17:15
9d55deb to
28ed8ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #891 split (5 of 5). Marked draft — depends on PR landing first.
Series progress
What this contains
demos/system-services-monitor/standalone demo subtreeWhat this does NOT contain
CR-ignored findings addressed
cc @XRFXLP