Feature improve integration tests - #38
Merged
Merged
Conversation
By using searched screencaps, sleeps can be removed as regenerating the same gif does not have a rate limit. This means integration tests can be reduced from ~120s to ~20s once sleeps are removed.
MitchellAW
force-pushed
the
feature-improve-integration-tests
branch
from
June 24, 2026 04:39
1b6227d to
b06e846
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use searched screencaps in integration tests, this allows the tests to take advantage of avoiding rate limits as generating gifs that have been generated previously do not have rate limits.
This reduces integration test times from ~120s to ~20s.
Add an additional integration test for generating a gif with customised subtitle formatting (font, color, size, uppercase/lowercase)
Removing the sleeps from the tests will causes tests to fail with 429 if the gifs are eventually removed, so the HTTP client will need some retrying capability to prevent this in future.