DEVOPS-1133: Pin GitHub Actions to commit hashes - #53
Open
RomFloreani wants to merge 5 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates GitHub Actions reusable workflow references in this repo from the major tag v3 to the more specific v3.9.1, as part of the DEVOPS-1133 effort to harden CI dependencies.
Changes:
- Updated Python deploy workflows (dev/prod) to use
MiraGeoscience/CI-toolsreusable workflows atv3.9.1. - Updated Python analysis workflow (static analysis + pytest) to use
v3.9.1. - Updated JIRA automation workflows (PR actions + issue-to-JIRA) to use
v3.9.1.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/python_deploy_prod.yml | Bumps reusable release workflows from @v3 to @v3.9.1. |
| .github/workflows/python_deploy_dev.yml | Bumps reusable publish workflows from @v3 to @v3.9.1. |
| .github/workflows/python_analysis.yml | Bumps reusable analysis workflows from @v3 to @v3.9.1. |
| .github/workflows/pr_jira_actions.yml | Bumps reusable JIRA PR workflow from @v3 to @v3.9.1. |
| .github/workflows/issue_to_jira.yml | Bumps reusable JIRA issue workflow from @v3 to @v3.9.1. |
Comments suppressed due to low confidence (3)
.github/workflows/python_deploy_prod.yml:40
- PR description says every
uses:should be pinned to an immutable commit SHA with a Dependabot-readable version comment. This workflow still references the floatingv3.9.1tag, which can be retagged and weakens supply-chain guarantees.
uses: MiraGeoscience/CI-tools/.github/workflows/reusable-python-release_pypi_assets.yml@v3.9.1
.github/workflows/python_deploy_dev.yml:28
- PR description says every
uses:should be pinned to an immutable commit SHA with a Dependabot-readable version comment. This workflow still references the floatingv3.9.1tag, which can be retagged and weakens supply-chain guarantees.
uses: MiraGeoscience/CI-tools/.github/workflows/reusable-python-publish_pypi_package.yml@v3.9.1
.github/workflows/python_analysis.yml:34
- PR description says every
uses:should be pinned to an immutable commit SHA with a Dependabot-readable version comment. This workflow still references the floatingv3.9.1tag, which can be retagged and weakens supply-chain guarantees.
uses: MiraGeoscience/CI-tools/.github/workflows/reusable-python-pytest.yml@v3.9.1
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEVOPS-1133 - pin all GitHub actions and reusable workflows to hash
Expands moving GitHub Actions tags to the full semver tag pointing at the same commit, then pins every
uses:to a commit hash with a dependabot-readable version comment.Tags expanded in this repo:
MiraGeoscience/CI-tools/.github/workflows/reusable-jira-issue_to_jira.yml@v3 -> @v3.9.1MiraGeoscience/CI-tools/.github/workflows/reusable-jira-pr_actions.yml@v3 -> @v3.9.1MiraGeoscience/CI-tools/.github/workflows/reusable-python-static_analysis.yml@v3 -> @v3.9.1MiraGeoscience/CI-tools/.github/workflows/reusable-python-pytest.yml@v3 -> @v3.9.1MiraGeoscience/CI-tools/.github/workflows/reusable-python-publish_rattler_package.yml@v3 -> @v3.9.1MiraGeoscience/CI-tools/.github/workflows/reusable-python-publish_pypi_package.yml@v3 -> @v3.9.1MiraGeoscience/CI-tools/.github/workflows/reusable-python-release_conda_assets.yml@v3 -> @v3.9.1MiraGeoscience/CI-tools/.github/workflows/reusable-python-release_pypi_assets.yml@v3 -> @v3.9.1