Update service principal creation command and use env variable for Subscription ID - #48
Open
wesmacdonald wants to merge 2 commits into
Open
Update service principal creation command and use env variable for Subscription ID#48wesmacdonald wants to merge 2 commits into
wesmacdonald wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Reduces some of the friction while going through the lab.
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
The first change is related to a policy error generating a password (if the end user has enabled the baseline security mode - 'block new password credentials in apps'. The password is not actually required for the lab so this avoids an error message being displayed.
The second change relates to an end user with multiple Azure Subscriptions; the code is unable to determine which subscription Application Insights is located in and throws 'ERROR: Could not find a matching Application Insights component in your subscription'. The subscription id exists as an environment variable, so this avoids the error all together.
How to Test
What to Check
Verify that the following are valid
'az ad sp create-for-rbac' command no longer creates a password
python src/tests/check_traces.py finds the correct Application Insights component
Other Information
A few paper cuts I found while doing the exercises.