Reject trailing data in PSBT global unsigned transactions - #1327
Open
KY-U wants to merge 1 commit into
Open
Conversation
Parse PSBT_GLOBAL_UNSIGNED_TX using the legacy transaction format required by BIP174 and ensure deserialization consumes the entire field value. Add an invalid PSBT vector containing a valid transaction followed by trailing data.
KY-U
changed the title
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes PSBTv0 parsing reject a
PSBT_GLOBAL_UNSIGNED_TXvalue when transaction deserialization does not consume the entire declared value as per the BIP174:It also explicitly parses the global unsigned transaction using legacy, non-witness transaction serialization, as required by the BIP.