Bump to v2.2.4 - #47
Merged
Merged
Conversation
gmat
reviewed
Jun 5, 2026
Collaborator
There was a problem hiding this comment.
it's look like you miss the 3 on python versions upper to 3.10.
The documentation of tox tag the pyNM and pyN.M as legacy maybe prevert futur release by using N.M notations
https://tox.wiki/en/latest/tutorial/getting-started.html#environment-names-and-python-versions
gmat
reviewed
Jun 5, 2026
| self.db_path = self.default_db | ||
| self.example_db = pkg_resources.resource_filename('isocor', 'data/') | ||
| # self.example_db = pkg_resources.resource_filename('isocor', 'data/') | ||
| self.example_db = importlib.resources.files('isocor') / 'data/' |
Collaborator
There was a problem hiding this comment.
I would use .joinpath('data') instead of / 'data' syntax but it good as it.
Collaborator
Author
There was a problem hiding this comment.
Thanks for the suggestion :-). Indeed, joinpath() is more explicit and improve readability.
added 5 commits
June 8, 2026 14:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacement of pkg_resources with importlib.resources for retrieving the path of the example database.
This change fixes the issue preventing the GUI from starting.
Update Python versions in tox.ini environment list