Add golden test for User/ListRsp with is_bot field - #159
Merged
Conversation
Covers users.list response deserialization with a fixture containing a human user, a bot user (is_bot: true), and a deleted user. Exercises the userIsBot field added in #158. Made-with: Cursor
rjmholt
force-pushed
the
rjmholt/add-user-golden-tests
branch
from
April 3, 2026 01:47
a990aee to
45a8d00
Compare
lf-
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
users.listresponse deserialization (ListRsp)is_bot: false) with full profileis_bot: true) without a profileis_bot: false,deleted: true)userIsBotfield added in Add userIsBot field to User type #158Test plan
userIsBot = Just Truefor the bot andJust Falsefor humansMade with Cursor