MDEV-40791 SET GLOBAL innodb_log_archive=OFF triggers full flush - #5576
Merged
Conversation
|
|
dr-m
marked this pull request as draft
August 20, 2026 09:56
dr-m
commented
Aug 20, 2026
log_t::set_archive(): When a checkpoint needs to be forced, set a minimum target that guarantees progress, instead of flushing the entire buffer pool. Remove some duplicated reads of last_checkpoint_lsn. When switching innodb_log_archive from OFF to ON, accurately remember whether any log records may have been written with get_sequence_bit() == 0, to ensure that a checkpoint will be waited for on a subsequent switch from ON to OFF. log_t::set_recovered(): If innodb_log_archive=ON, only make a future set_archive(false) trigger a checkpoint if we may have recovered a server that was killed between set_archive(true) and write_checkpoint().
dr-m
marked this pull request as ready for review
August 20, 2026 11:29
Thirunarayanan
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
log_t::set_archive(): When a checkpoint needs to be forced, set a minimum target that guarantees progress, instead of flushing the entire buffer pool. Remove some duplicated reads oflast_checkpoint_lsn.When switching
innodb_log_archivefromOFFtoON, accurately remember whether any log records may have been written withget_sequence_bit() == 0, to ensure that a checkpoint will be waited for on a subsequent switch fromONtoOFF.log_t::set_recovered(): Ifinnodb_log_archive=ON, only make a futureset_archive(false)trigger a checkpoint if we may have recovered a server that was killed betweenset_archive(true)andwrite_checkpoint().