Restructure tasks/ into ai/common/tests/, organize tests/ into marker subfolders - #19
Merged
Merged
Conversation
Mirrors the same restructuring just done in fireball_orchestrator (a
downstream consumer of this template), scoped to what actually exists here:
- tasks/ai/{repo,template}.py -- tooling downstream repos use to operate on
themselves (git/PR workflow, parent-template sync). Kept at their original
top-level repo.*/template.* names.
- tasks/common/{main,debug,ruff,setup,upgrade,uv,versioning}.py --
template_python-inherited boilerplate. main.py replaces combos.py (same
fix/test/update aliases). Kept at their original top-level names too.
- tasks/tests/ -- tasks/tests.py split into one file per check (actionlint,
check_agents, pylint, pytest, rufflint, yamllint), still one flat tests.*
namespace. check_agents.py now runs `pytest -m "agents"` instead of a
hardcoded file path, so it doesn't go stale if that test file ever moves
again.
No CLI surface change from any of the above -- every task in this repo
invokes identically to before.
Also organized the actual pytest suite (tests/) into marker-named
subfolders (agents/, setup/, style/), added a markers list to
pyproject.toml, and gave tasks/tests/pytest.py a scope= param for
marker-filtered subset runs (invoke tests.pytest scope=agents). Fixed each
moved test file's REPO_ROOT parents[] index for the new nesting depth.
README.md and .github/instructions/{index,tasks}.instructions.md updated to
match, including documenting a real bug found while restructuring:
Collection(auto_dash_names=...) must be a constructor kwarg, not a
.configure({"auto_dash_names": False}) call (which silently does nothing).
Companion to the template_python PR this repo forks from.
Generated with Claude Code
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors the same restructuring just done in
fireball_orchestrator(a downstream consumer of this template), scoped to what actually exists here.tasks/— split into subpackages, every task kept at its original top-level invoke name (no CLI surface change):tasks/ai/{repo,template}.py— tooling downstream repos use to operate on themselves (git/PR workflow, parent-template sync).tasks/common/{main,debug,ruff,setup,upgrade,uv,versioning}.py— template_python-inherited boilerplate.main.pyreplacescombos.py(samefix/test/updatealiases).tasks/tests/—tasks/tests.pysplit into one file per check, still one flattests.*namespace.check_agents.pynow runspytest -m "agents"instead of a hardcoded file path.tests/— the actual pytest suite organized into marker-named subfolders (agents/,setup/,style/), matchingfireball_orchestrator's owntests/layout.pyproject.tomlgained amarkerslist;tests.pytestgained ascope=param for marker-filtered subset runs (invoke tests.pytest scope=agents).Also documents a real bug found while restructuring:
Collection(auto_dash_names=...)must be a constructor kwarg, not a.configure({"auto_dash_names": False})call (which silently does nothing) — fixed everywhere, noted intasks.instructions.md.Companion to template_python#2, the parent this repo forks from.
🤖 Generated with Claude Code