just remove any reference to halfwise pages - #454
Draft
tomeichlersmith wants to merge 1 commit into
Draft
Conversation
tomeichlersmith
marked this pull request as draft
August 6, 2026 18:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the HGCROC manual mentions
HALFWISE_0andHALFWISE_1and our register maps match the documented addresses listed there, I am not able to observe understandable behavior from them which makes me think that they are an experimental feature that is still buggy.For example, when I write
CHANNEL_OFF: 1toHALFWISE_1, I would expect eitherHALFWISE_1.CHANNEL_OFFto read back as0butCH_##.CHANNEL_OFFto read back as1for all##[36, 71].HALFWISE_1.CHANNEL_OFFto read back as1, theCH_##.CHANNEL_OFFparameters would still read back as0, but the channels in that half would behave like they were off.I don't observe either of these behaviors, so I think avoiding this page is the best strategy moving forward. If we get newer versions of the HGCROC or its documentation that update this understanding, we can re-introduce these short-cut parameters.
This indirectly resolves #155 and indirectly resolves #344 by simply removing the page that was causing confusion.
To be clear, I do observe option (1) above for other parameters that are not
CHANNEL_OFF(likeADC_PEDESTAL) which does make sense. Maybe I'll just try to removeCHANNEL_OFFfrom the halfwise page to avoid confusion in the future.