Skip to content

just remove any reference to halfwise pages - #454

Draft
tomeichlersmith wants to merge 1 commit into
mainfrom
remove-halfwise-pages
Draft

just remove any reference to halfwise pages#454
tomeichlersmith wants to merge 1 commit into
mainfrom
remove-halfwise-pages

Conversation

@tomeichlersmith

@tomeichlersmith tomeichlersmith commented Aug 6, 2026

Copy link
Copy Markdown
Member

While the HGCROC manual mentions HALFWISE_0 and HALFWISE_1 and our register maps match the documented addresses listed there, I am not able to observe understandable behavior from them which makes me think that they are an experimental feature that is still buggy.

For example, when I write CHANNEL_OFF: 1 to HALFWISE_1, I would expect either

  1. The halfwise pages are write only and the values written to them are copied onto all of the channels for that half. In this case, I would expect HALFWISE_1.CHANNEL_OFF to read back as 0 but CH_##.CHANNEL_OFF to read back as 1 for all ## [36, 71].
  2. The halfwise pages are parameters that are overlaid on top of the channel parameters if they are non-zero. In this case, I would expect HALFWISE_1.CHANNEL_OFF to read back as 1, the CH_##.CHANNEL_OFF parameters would still read back as 0, but the channels in that half would behave like they were off.

I don't observe either of these behaviors, so I think avoiding this page is the best strategy moving forward. If we get newer versions of the HGCROC or its documentation that update this understanding, we can re-introduce these short-cut parameters.

This indirectly resolves #155 and indirectly resolves #344 by simply removing the page that was causing confusion.

To be clear, I do observe option (1) above for other parameters that are not CHANNEL_OFF (like ADC_PEDESTAL) which does make sense. Maybe I'll just try to remove CHANNEL_OFF from the halfwise page to avoid confusion in the future.

@tomeichlersmith
tomeichlersmith marked this pull request as draft August 6, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't dump HALFWISE page to .yaml Poking parameters halfwise inconsistency

1 participant