ci: add Docker build/push workflow to GHCR#109
Merged
Conversation
mohit-nagaraj
requested review from
Kshitijknk07,
Naman-B-Parlecha and
rishichirchi
as code owners
April 12, 2026 04:01
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Dockerfile to use Go 1.25 and modifies the configuration file copy command to use a glob pattern for optional inclusion. However, several critical issues were identified: Go 1.25 is not a released version, which will cause build failures; the build process hardcodes the architecture despite claims of multi-platform support; and a referenced workflow file is missing from the PR. Additionally, the glob pattern for configuration files may inadvertently include unnecessary files like examples in the production image.
- Add docker-publish.yml: builds and pushes ghcr.io/kubeorch/core on push to main (latest) and version tags (v*); multi-platform linux/amd64 + linux/arm64 via TARGETARCH/TARGETOS build args - Fix Dockerfile: bump Go 1.22 -> 1.23 (latest stable), use ARG TARGETOS/TARGETARCH for correct multi-platform binaries, remove config.yaml copy (configuration is provided via env vars or a mounted file at runtime) Signed-off-by: Mohit Nagaraj <mohitnagaraj20@gmail.com>
mohit-nagaraj
force-pushed
the
ci/docker-build-push
branch
from
April 14, 2026 06:34
afb7f87 to
20878b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker-publish.ymlworkflow that builds and pushes toghcr.io/kubeorch/coreon push to main (latesttag) and version tags (v*)linux/amd64+linux/arm64config.yamlcopy (was failing when file didn't exist)go.modTest plan
ghcr.io/kubeorch/core:latestdocker run ghcr.io/kubeorch/core:latest