test(e2e): stabilize software-rendered browser runs - #917
Merged
Conversation
✅ Deploy Preview for volview-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Six software-rendered Chrome instances can starve the browser and WebDriver long enough for otherwise healthy views to exceed the 20-second render timeout. Timed-out pages recovered without a reload once CPU pressure eased. CI already runs one instance and sets
DOWNLOAD_TIMEOUT=90000, so these concurrency and default-timeout changes are local-only.The first CI run for this PR exposed a separate race in
layers-and-rendering.e2e.ts. The test waited for two dataset menus, then always opened the second menu. Add Layer is only available after a primary dataset is active and only on a different dataset, so the test could wait for an element that should not exist. It now waits for both active and inactive datasets and opens an inactive dataset's menu.The Linux GL backend experiment was removed from this PR so renderer changes can be evaluated independently.
Tested
npm run test:e2e:chrome— 30/30 spec files passed with three local Chrome instanceslayers-and-rendering.e2e.tsunder the existing CI-style Xvfb configuration — 10 consecutive passesnpm run lintgit diff --check