Skip to content

Added an example for entropy simulation.#493

Open
DoktorMike wants to merge 4 commits into
JuliaAnimators:mainfrom
DoktorMike:doktormike-issue-492
Open

Added an example for entropy simulation.#493
DoktorMike wants to merge 4 commits into
JuliaAnimators:mainfrom
DoktorMike:doktormike-issue-492

Conversation

@DoktorMike

Copy link
Copy Markdown

PR Checklist

If you are contributing to Javis.jl, please make sure you are able to check off each item on this list:

  • Did I update CHANGELOG.md with whatever changes/features I added with this PR?
  • Did I make sure to only change the part of the file where I introduced a new change/feature?
  • Did I cover all corner cases to be close to 100% test coverage (if applicable)?
  • Did I properly add Javis dependencies to the Project.toml + set an upper bound of the dependency (if applicable)?
  • Did I properly add test dependencies to the test directory (if applicable)?
  • Did I check relevant tutorials that may be affected by changes in this PR?
  • Did I clearly articulate why this PR was made the way it was and how it was made?

Link to relevant issue(s)
Closes #492

How did you address these issues with this PR? What methods did you use?

I just made a small example and put it in a file called entropy.jl under examples. Nothing else touched.

@DoktorMike

Copy link
Copy Markdown
Author

See https://discourse.julialang.org/t/javis-collision-detection/87398/10 for a discussion on the example and why I submitted this. :)

@Sov-trotter

Sov-trotter commented Sep 20, 2022

Copy link
Copy Markdown
Member

Thanks for this!
Could you also add an animation gif to the gifs folder? https://github.com/JuliaAnimators/Javis.jl/tree/main/examples/gifs

@codecov-commenter

codecov-commenter commented Sep 20, 2022

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.24%. Comparing base (1e74392) to head (6ee42ab).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #493      +/-   ##
==========================================
- Coverage   77.74%   77.24%   -0.51%     
==========================================
  Files          38       38              
  Lines        1991     2070      +79     
==========================================
+ Hits         1548     1599      +51     
- Misses        443      471      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread examples/entropy.jl Outdated
@DoktorMike

Copy link
Copy Markdown
Author

Thanks for this! Could you also add an animation gif to the gifs folder? https://github.com/JuliaAnimators/Javis.jl/tree/main/examples/gifs

Done.

@TheCedarPrince

Copy link
Copy Markdown
Member

I activated the CI for this - will review this PR asap and see if we can get this merged. Thanks @DoktorMike - you the best! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Educational Entropy example

5 participants