Fix encryptedDerivePublic to return Either instead of throwing on har…#687
Merged
Conversation
…dened indices Replace both partial `error` branches in `encryptedDerivePublic` with structured failures: hardened indices now return `Left XPrvHardenedDerivationUnsupported` and FFI failures return `Left XPrvInternalError`. The return type changes from the pure `(PublicKey, ChainCode)` to `Either XPrvError (PublicKey, ChainCode)`, matching the style of the sibling `encryptedDerivePrivate` API and eliminating the crash vector when callers forward attacker-controlled derivation paths.
lehins
requested changes
Jul 13, 2026
lehins
left a comment
lehins
left a comment
Collaborator
There was a problem hiding this comment.
Aside from missing necessary version bump and changelog it looks good. Thank you!
Collaborator
|
Oh yeah, and it needs some |
Breaking API change from previous commit: version bump, changelog entry, and fourmolu formatting fix in RoundTripSpec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…dened indices
Replace both partial
errorbranches inencryptedDerivePublicwith structured failures: hardened indices now returnLeft XPrvHardenedDerivationUnsupportedand FFI failures returnLeft XPrvInternalError. The return type changes from the pure(PublicKey, ChainCode)toEither XPrvError (PublicKey, ChainCode), matching the style of the siblingencryptedDerivePrivateAPI and eliminating the crash vector when callers forward attacker-controlled derivation paths.Description
Checklist
CHANGELOG.mdfor the affected packages.New section is never added with the code changes. (See RELEASING.md)
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated.If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)