-
Notifications
You must be signed in to change notification settings - Fork 76
Update sklearnex gpu to use array_api_dispatch and dpnp #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,12 +6,18 @@ | |
| { "library": "sklearnex", "device": "cpu" } | ||
| ] | ||
| }, | ||
| "sklearn-ex[cpu,gpu] implementations": { | ||
| "algorithm": [ | ||
| { "library": "sklearn", "device": "cpu" }, | ||
| { "library": "sklearnex", "device": ["cpu", "gpu"] } | ||
| ] | ||
| }, | ||
| "sklearn-ex[cpu,gpu] implementations": [ | ||
| { "algorithm": { "library": "sklearn", "device": "cpu" } }, | ||
| { "algorithm": { "library": "sklearnex", "device": "cpu" } }, | ||
| { | ||
| "algorithm": { | ||
| "library": "sklearnex", | ||
| "device": "gpu", | ||
| "sklearn_context": { "array_api_dispatch": true } | ||
| }, | ||
| "data": { "format": "dpnp" } | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please double check that C order is used |
||
| } | ||
| ], | ||
| "sklearnex spmd implementation": { | ||
| "algorithm": { | ||
| "library": "sklearnex.spmd", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -147,6 +147,10 @@ def get_subset_metrics_of_estimator( | |
| and getattr(estimator_instance, "probability") == False | ||
| ): | ||
| y_pred_proba = convert_to_numpy(estimator_instance.predict_proba(x)) | ||
| # GPU/float32 predict_proba rows may drift outside roc_auc_score's | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should be fixed in sklearnex instead. There is a code branch like this for random forests. If it happens for other classes, needs to be added for them too. |
||
| # sum-to-one tolerance for multiclass, so renormalize before scoring | ||
| if y_pred_proba.shape[1] > 2: | ||
| y_pred_proba = y_pred_proba / y_pred_proba.sum(axis=1, keepdims=True) | ||
| metrics.update( | ||
| { | ||
| "ROC AUC": float( | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like it could be set inside the python process instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could but I don't think this is a great way to handle it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ethanglaser What would be the downside?