Skip to content

Fix abort in top_k for k=0 #3022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonwolfy merged 2 commits into from
Aug 13, 2026
+2 −1
Merged

Fix abort in top_k for k=0 #3022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6c19b4
Guard topk against k == 0
antonwolfy Aug 12, 2026
588e039
Update changelog for topk k == 0 fix
antonwolfy Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ This release is compatible with NumPy 2.5.
* Fixed `dpnp.interp` returning `nan` when querying at an exact knot point whose adjacent `fp` value is `inf` [#2986](https://github.com/IntelPython/dpnp/pull/2986)
* Fixed missing strides validation in `dpnp.tensor.usm_ndarray` constructor when allocating new memory [#2927](https://github.com/IntelPython/dpnp/pull/2927)
* Fixed `dpnp.bincount` raising a `ValueError` on an empty input array instead of returning an empty `intp` array [#3018](https://github.com/IntelPython/dpnp/pull/3018)
* Fixed `dpnp.tensor.top_k` aborting for `k=0` by returning empty result arrays without launching a zero-sized kernel [#3022](https://github.com/IntelPython/dpnp/pull/3022)

### Security

Expand Down
2 changes: 1 addition & 1 deletion dpnp/tensor/libtensor/source/sorting/topk.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ std::pair<sycl::event, sycl::event>
dpnp::tensor::validation::CheckWritable::throw_if_not_writable(vals);
dpnp::tensor::validation::CheckWritable::throw_if_not_writable(inds);

if ((iter_nelems == 0) || (axis_nelems == 0)) {
if ((iter_nelems == 0) || (axis_nelems == 0) || (k == 0)) {
// Nothing to do
return std::make_pair(sycl::event(), sycl::event());
}
Expand Down
Loading