fix(i18n): handle missing date formats - #17501
Open
viktorkombov wants to merge 1 commit into
Open
Conversation
viktorkombov
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a regression in Ignite UI’s BaseFormatter.formatDate() when running under Angular 22.1+ by preventing Angular’s formatDate() from being called with a missing/empty format string (which can throw due to .length validation added upstream).
Changes:
- Broadened
BaseFormatter.formatDate()’sformatparameter type to allownull | undefinedand added a guard to return''when the format is missing/empty. - Added a regression unit test covering
undefined,null, and''format inputs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| projects/igniteui-angular/core/src/core/i18n/formatters/formatter-base.ts | Avoids calling Angular formatDate() when format is missing/empty by widening type + adding a guard. |
| projects/igniteui-angular/core/src/core/i18n/formatters/formatter-base.spec.ts | Adds regression coverage for missing/empty format values returning an empty string. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+80
to
+81
| public formatDate(value: Date | string | number | null | undefined, format: string | null | undefined, locale: string, timezone?: string): string { | ||
| return value != null && format ? ngFormatDate(value, format, locale, timezone) : ''; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17493
Description
Prevents Angular 22.1 from throwing when a date format is null, undefined, or empty. Preserves the previous empty-string behavior and adds regression coverage.
Motivation / Context
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)