fix(grid): ensure resize observer is only created if available in ssr - 22.0.x - #17499
Open
mddragnev wants to merge 1 commit into
Open
fix(grid): ensure resize observer is only created if available in ssr - 22.0.x#17499mddragnev wants to merge 1 commit into
mddragnev wants to merge 1 commit into
Conversation
mddragnev
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an SSR runtime error by preventing ResizeObserver construction when it’s unavailable (e.g., server-side rendering), in the IgxGridForOfDirective virtualization flow (used by the grid).
Changes:
- Guard
ResizeObserverinstantiation inngOnInit()by checkinggetResizeObserver()result before constructing. - Avoid SSR crashes when
window.ResizeObserveris undefined.
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17497
Description
Motivation / Context
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)