URB-3568: handle abandon notification#587
Open
WBoudabous wants to merge 4 commits into
Open
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThe PR adds abandonment notice routing in ChangesAbandonment notification updates
Deposit migration update
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
mpeeters
changed the title
mpeeters
requested changes
Jun 23, 2026
| "podTemplates": (), | ||
| "eventType": ("Products.urban.interfaces.IDecisionProjectFromSPWEvent",), | ||
| "TALCondition": "python: licence.getProcedureChoice() != 'article65'", | ||
| }, |
Member
There was a problem hiding this comment.
We do not use this file anymore, it is almost unmaintainable, please create the events into urban.event https://github.com/IMIO/urban.events/
| logger.info("upgrade step done!") | ||
|
|
||
|
|
||
| def add_dossier_abandonne_event(context): |
Member
There was a problem hiding this comment.
This will be moved to urban.event as well as the configuration of events
WBoudabous
force-pushed
the
URB-3568_handle_ABANDON_notification
branch
from
6baa54f to
2b6ffc9
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/Products/urban/migration/update_290.py`:
- Around line 545-649: Remove the unresolved merge-conflict markers in the
migration module so the file parses again; keep the intended logic from both
sides by preserving add_digital_term_to_deposit_type and
normalize_externaldecisions_vocabulary, and ensure the final
logger.info("upgrade step done!") remains in the correct function flow without
any <<<<<<<, =======, or >>>>>>> tokens.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 4523435f-f8eb-40b5-9c3b-110881690835
📒 Files selected for processing (6)
news/URB-3568.featuresrc/Products/urban/browser/cron/notice.pysrc/Products/urban/locales/fr/LC_MESSAGES/urban.posrc/Products/urban/locales/urban-manual.potsrc/Products/urban/locales/urban.potsrc/Products/urban/migration/update_290.py
✅ Files skipped from review due to trivial changes (3)
- news/URB-3568.feature
- src/Products/urban/locales/urban.pot
- src/Products/urban/locales/fr/LC_MESSAGES/urban.po
🚧 Files skipped from review as they are similar to previous changes (2)
- src/Products/urban/locales/urban-manual.pot
- src/Products/urban/browser/cron/notice.py
WBoudabous
force-pushed
the
URB-3568_handle_ABANDON_notification
branch
from
2626ecc to
3321d8d
Compare
mpeeters
requested changes
Jun 25, 2026
| new_term = getattr(voc_folder, vocabulary_term) | ||
| new_term.setDescription(DESCRIPTION) | ||
| logger.info("Created missing vocabulary term: %s", vocabulary_term) | ||
| logger.info("upgrade step done!") |
Comment on lines
+1
to
+3
| Add handling of ABANDON_COMMUNE_MANUELLE, PM_ABANDON_COMMUNE_EP, and PM_ABANDON_COMMUNE_EP_FTFD notification. | ||
| Add dossier-abandonne event config to codt_uniquelicence, envclassone and envclasstwo licence configs. | ||
| Add upgrade step 2916 to create dossier-abandonne event config on existing installations. |
Member
There was a problem hiding this comment.
Please update changelog to reflect recent changes
WBoudabous
force-pushed
the
URB-3568_handle_ABANDON_notification
branch
from
041897f to
058d2c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Adds support for the ABANDON_COMMUNE_MANUELLE, PM_ABANDON_COMMUNE_EP, and PM_ABANDON_COMMUNE_EP_FTFD notifications.
Introduces the dossier-abandonne event configuration for codt_uniquelicence, envclassone, and envclasstwo licences, and adds upgrade step 2916 to create the configuration on existing installations.
It depends on IMIO/urban.events#9
Summary by CodeRabbit