Skip to content

[FIX] #46107 UI: update MainControls\Footer section one size. - #10372

Merged
thibsy merged 2 commits into
ILIAS-eLearning:release_10from
srsolutionsag:fix/10/ui-footer-section-sizes
Aug 5, 2026
Merged

[FIX] #46107 UI: update MainControls\Footer section one size.#10372
thibsy merged 2 commits into
ILIAS-eLearning:release_10from
srsolutionsag:fix/10/ui-footer-section-sizes

Conversation

@thibsy

@thibsy thibsy commented Nov 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Hi all, this

Kind regards
@thibsy

@thibsy
thibsy force-pushed the fix/10/ui-footer-section-sizes branch 2 times, most recently from c72926b to 712c455 Compare November 5, 2025 08:44
@dsstrassner

dsstrassner commented Dec 29, 2025

Copy link
Copy Markdown
Contributor

Hi @oliversamoila, I think you should discuss with @thibsy how to proceed in the future with this PR 🙈

oliversamoila
oliversamoila reviewed Jan 5, 2026
View reviewed changes

@oliversamoila oliversamoila left a comment •
edited by thibsy
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @thibsy .
Thank you for the PR. The result looks good in the user interface.
(See also screenshots in Mantis 46107)
I just want to ask whether you would like to have the column adjustment for the row with 'powered by ILIAS M.N yyyy.mm.dd' as well.

Let's have a talk about how we proceed with the code review here.
Best regards,
Oliver (as UI coordinator)

@dsstrassner

dsstrassner commented Jan 5, 2026

Copy link
Copy Markdown
Contributor

https://mantis.ilias.de/view.php?id=46107#c121382 -->

@oliversamoila changes are somewhat trivial, your UI/UX feedback will be sufficient.

One question we might discuss in this scope: should section 4 be changed to two column grid as well? In your screenshots the "powered by [...]" is also "suffering" from the same issue.

oliversamoila
oliversamoila requested changes Jan 5, 2026
View reviewed changes

@oliversamoila oliversamoila left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thibeau and I have already discussed this briefly. In our opinion, you mean section 5.

Section 5 (text): the text section is composed of text information contained in an unordered list.
section 4 refers to icons.

section 5 should also behave like section 1 (following the changes of this PR) and should have the same grid.

Thank you all.

@BettyFromHH BettyFromHH added the css/html Pull requests that propose changes to CSS/SCSS or HTML files. label Jan 21, 2026
@oliversamoila oliversamoila mentioned this pull request May 28, 2026
Open
thibsy added a commit to srsolutionsag/ILIAS that referenced this pull request Aug 5, 2026
@thibsy
[FIX] #46107 UI: update MainControls\Footer section sizes (ILIAS-eL…
1257327 
…earning#10372)

* Fixes https://mantis.ilias.de/view.php?id=46107
* Update section 1 and 5 from 4 column grid to 2 column grid
* Add section grid size CSS modifier
@thibsy
thibsy force-pushed the fix/10/ui-footer-section-sizes branch from 712c455 to 8f8d4c4 Compare August 5, 2026 12:36
@thibsy
thibsy force-pushed the fix/10/ui-footer-section-sizes branch from 8f8d4c4 to e09272d Compare August 5, 2026 12:43
thibsy
thibsy commented Aug 5, 2026
View reviewed changes

@thibsy thibsy left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel pretty confident about this, so I will not pass this through the shepherd process.

@thibsy
thibsy merged commit 3bd1b93 into ILIAS-eLearning:release_10 Aug 5, 2026
2 checks passed
thibsy added a commit that referenced this pull request Aug 5, 2026
@thibsy
[FIX] #46107 UI: update MainControls\Footer section sizes (#10372)
246ee93 
* Fixes https://mantis.ilias.de/view.php?id=46107
* Update section 1 and 5 from 4 column grid to 2 column grid
* Add section grid size CSS modifier
thibsy added a commit that referenced this pull request Aug 5, 2026
@thibsy
[FIX] #46107 UI: update MainControls\Footer section sizes (#10372)
d2d7bef 
* Fixes https://mantis.ilias.de/view.php?id=46107
* Update section 1 and 5 from 4 column grid to 2 column grid
* Add section grid size CSS modifier
thibsy added a commit that referenced this pull request Aug 5, 2026
@thibsy
[FIX] #46107 UI: update MainControls\Footer section sizes (#10372)
aed700b 
* Fixes https://mantis.ilias.de/view.php?id=46107
* Update section 1 and 5 from 4 column grid to 2 column grid
* Add section grid size CSS modifier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliversamoila oliversamoila oliversamoila requested changes

Assignees

@thibsy thibsy

@oliversamoila oliversamoila

Labels

bugfix css/html Pull requests that propose changes to CSS/SCSS or HTML files. kitchen sink

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@thibsy @dsstrassner @oliversamoila @klees @yvseiler @catenglaender @BettyFromHH