Skip to content

currentCulture set to invariant instead system choice - #51

Open
iseeeva wants to merge 1 commit into
HarGabt:1.0.7from
iseeeva:1.0.7
Open

currentCulture set to invariant instead system choice#51
iseeeva wants to merge 1 commit into
HarGabt:1.0.7from
iseeeva:1.0.7

Conversation

@iseeeva

@iseeeva iseeeva commented Apr 5, 2026

Copy link
Copy Markdown

for #46 issue

@HarGabt

HarGabt commented Apr 15, 2026

Copy link
Copy Markdown
Owner

I think this issue can be solved by replacing certain ToLower instance(s) to ToLowerInvariant one

Refer to CadeEvs#209, a contributor there also had some issues with Turkish locale due to ToLower implementation and usage

@iseeeva

iseeeva commented Apr 30, 2026

Copy link
Copy Markdown
Author

default culture looks way more useful than changing every method to invariant alternatives
or we can strict the project to en-US rules instead

@shoushou1106

shoushou1106 commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

In my opinion, this pr will conflict with #56 . Because if this fork is going to support multi language, currentCulture could be used to detect user's language preference and select language automatically for user. This would be very convenient, especially for those who cannot find where is Frosty config located.

@shoushou1106

shoushou1106 commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

If this issue must be fixed by changing currentCulture, you could try use a Thread where the issue actually happens, instead of killing a .net i18n feature.

https://github.com/CadeEvs/FrostyToolsuite/pull/343/changes#diff-5431f8466c337a05a26f4bc265f43bd924832c47286a819f2196431fc5e666efR160

System.Threading.Thread thread = new System.Threading.Thread(() =>
{
    // Do something
})
{
    // Set CurrentCulture for the thread
    CurrentCulture = CultureInfo.InvariantCulture,
    CurrentUICulture = CultureInfo.InvariantCulture
};
thread.Start(); // Execute the thread
thread.Join(); // Wait until the thread finish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants