feat(path): expose *Path-related utility functions - #349
Open
cartercanedy wants to merge 6 commits into
Open
Conversation
cartercanedy
changed the title
*Path-related utility functions*Path-related utility functions
Contributor
Author
uklotzde
reviewed
Jul 30, 2026
uklotzde
left a comment
uklotzde
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for your contribution and apologies for not responding promptly. Unfortunately we are currently very busy and didn't find the time for an in-depth review yet.
I left some initial comments.
| /// See [UA_RelativePath_parse](https://open62541.org/doc/master/util.html#example-relativepaths) docs. | ||
| pub fn parse(path: &str) -> Result<Self, Error> { | ||
| let path = ua::String::new(path)?; | ||
| let mut slf = Self::init(); |
Collaborator
There was a problem hiding this comment.
parsed_path would be a better name here instead of a cryptic abbreviation.
| @@ -1,4 +1,11 @@ | |||
| use crate::ua; | |||
| use std::fmt; | |||
Collaborator
There was a problem hiding this comment.
Please group the imports consistently with the existing code in this crate.
| "failed to print relative path: {status_code}" | ||
| ); | ||
|
|
||
| write!(f, "{str}") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #348
Implements
UA_RelativePathfactories/methods:UA_RelativePath_parse->ua::RelativePath::parse() -> Result<Self>UA_RelativePath_print->impl Display for ua::RelativePathAccesser methods were also implemented.