[Enhancement] 附加内容-检查更新功能优化 - #6531
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ea4c963430
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
话说 是不是可以把 #6552 顺带修了? |
Not planned. 那个纯纯模组自己的问题。 |
彳亍 |
# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/AddonUpdatesPage.java # HMCLCore/src/main/java/org/jackhuang/hmcl/addon/RemoteAddon.java # HMCLCore/src/main/java/org/jackhuang/hmcl/addon/mod/LocalModFile.java # HMCLCore/src/main/java/org/jackhuang/hmcl/addon/repository/CurseForgeRemoteAddonRepository.java # HMCLCore/src/main/java/org/jackhuang/hmcl/addon/repository/ModrinthRemoteAddonRepository.java # HMCLCore/src/main/java/org/jackhuang/hmcl/addon/resourcepack/ResourcePackZipFile.java
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bc0aa10fed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
# Conflicts: # HMCLCore/src/main/java/org/jackhuang/hmcl/addon/mod/LocalModFile.java # HMCLCore/src/main/java/org/jackhuang/hmcl/addon/resourcepack/ResourcePackZipFile.java
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1fbb760b0f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| /// Whether to update addons to preview versions | ||
| @SerializedName("updateAddonsToPreview") |
There was a problem hiding this comment.
这真的应该放在设置里吗？我觉得应该是每次检查更新的时候进行切换，而不是在全局丢一个这样的选项。
There was a problem hiding this comment.
这真的应该放在设置里吗？我觉得应该是每次检查更新的时候进行切换，而不是在全局丢一个这样的选项。
点击检查更新按钮后就直接开始了，然后出现检查的结果。这其中怎么放这个选项？
There was a problem hiding this comment.
现在打算检查更新的时候保留全版本候选和正式版候选，然后在那个表格页面加个checkbox
# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/AddonUpdatesPage.java # HMCLCore/src/main/java/org/jackhuang/hmcl/addon/LocalAddonFile.java # HMCLCore/src/main/java/org/jackhuang/hmcl/addon/RemoteAddon.java # HMCLCore/src/main/java/org/jackhuang/hmcl/addon/mod/LocalModFile.java # HMCLCore/src/main/java/org/jackhuang/hmcl/addon/repository/CurseForgeRemoteAddonRepository.java # HMCLCore/src/main/java/org/jackhuang/hmcl/addon/repository/ModrinthRemoteAddonRepository.java # HMCLCore/src/main/java/org/jackhuang/hmcl/addon/resourcepack/ResourcePackFolder.java # HMCLCore/src/main/java/org/jackhuang/hmcl/addon/resourcepack/ResourcePackZipFile.java
4 participants
检查更新时找到合适的最新版本，不再与当前版本的发布时间进行比较在跨版本更新时不对发布时间进行限制，从而解决大部分循环更新/跨版本无法更新的问题Fixes #5865 Fixes #3841 Fixes #3705
#4839 由于修复了就会引入新问题所以暂时不纳入考量