Skip to content

fix: Respect Federation version in @link directive - #222

Open
lyricsboy wants to merge 2 commits into
Gusto:mainfrom
lyricsboy:fix/respect-federation-version-in-link-directive
Open

fix: Respect Federation version in @link directive#222
lyricsboy wants to merge 2 commits into
Gusto:mainfrom
lyricsboy:fix/respect-federation-version-in-link-directive

Conversation

@lyricsboy

@lyricsboy lyricsboy commented Feb 23, 2023

Copy link
Copy Markdown

Problem

The federation version, though specifiable in the schema configuration, was not reflected in the @link directive URL when output via the federation_sdl method.

Solution

Use the federation_version as specified when building the URL.

@lyricsboy
lyricsboy force-pushed the fix/respect-federation-version-in-link-directive branch from 0e717ea to e5eb20f Compare February 23, 2023 21:21
@lyricsboy lyricsboy changed the title Respect Federation version in @link directive fix: Respect Federation version in @link directive Feb 23, 2023
@lyricsboy
lyricsboy marked this pull request as ready for review February 23, 2023 21:49
@dzmitry-miadzvedzeu

Copy link
Copy Markdown

Hello Everyone.

I want to clarify the status of this PR, if this change is considered a "breaking change", and hence, not possible to merge right now (reference to #267)?

Thank you in advance for your time and assistance.

@Kaytal

Kaytal commented Sep 30, 2024

Copy link
Copy Markdown

I know it's been a while since this PR was originally opened. However, I second this PR. It shouldn't be considered a breaking change any more than defining your federation version: 2.1 and getting a @link spec that matches federation 2.3. Additionally, locking the specification to 2.3 prevents many additional improvements and directives on later versions of Apollo Federation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants