return all partitions and disks in linux, regardless of mount status - take 2 - #1590
Draft
LinuxSquare wants to merge 18 commits into
Draft
return all partitions and disks in linux, regardless of mount status - take 2#1590LinuxSquare wants to merge 18 commits into
LinuxSquare wants to merge 18 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Well, I would say this is my try to fix this issue mentioned in #1181
(Since I stumbled over it as well).
What I've additionally added was, to read the
/proc/partitionsand have it pass as an additional parameter toget_all_list().If the fs-type is not known, I'll have it say
<unknown>instead.Additionally I've edited the debug message as well, since it's weird if it prints
mounted on "", even though it's not mounted. On unmounted disks it'll now saynot mountedI've also sorted out, possible
/dev/sr*, since it's not a "real" disk, more an optical drive.Looking at PR #1251
I saw that you also have loop devices in
/proc/partitions.I couldn't find any references on possible content of
/proc/partitions, so if you have any devices which aren't currently listed in the filter block, feel free to tell me, so I can adjust it further. :)